From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C40AEA0C4C; Mon, 4 Oct 2021 13:13:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FF394132B; Mon, 4 Oct 2021 13:13:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 22FED41325 for ; Mon, 4 Oct 2021 13:13:28 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1948CIqU013065; Mon, 4 Oct 2021 04:13:27 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by mx0b-0016f401.pphosted.com with ESMTP id 3bfc9yagsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Oct 2021 04:13:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pg/o95vxdWqqUtA+VahwuY9rYPgMzuFUWzmne04X/O0DOueYYqmqd+Rx4miPcvhhrPyBim4j86okXlNRh0s0wn2QIocirgvWEGNrFTBVICk+0kknM4wF/vF8bOLlcuCkxAaFz4C/mpnlg/t9TVyRlKMsHOGyz2kt02CI4CW0d7bJrQv+AgLhaQmi6qhTTciUurTiSdKN0P8IIKjn1QmaoPiQ/RO4mWf8gtQ0PsWklD7VjKoW3pUHDDjjeeiwwZ/bDLpNL55/F3TNdllnfP/+rWo4zNkRxl3AYfsotgZzx1+n+YPL8cVXwRhHMn7m9zBy6goN5oj6hrNuXwYNz9ym9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GAQz6hdN/oY2e42o/jNys6kkdajCn3PKkkCWwLawsQA=; b=I9a4HNP7wjT/ReKDUK6DxWlS7T2uFahFmctYnoJmMpNdh4szZF326sQQJjqqXbbyemTuWz8x8yKPQsnkgWoADhfeCdBBaUqwSIkFzEMkdgxTNTwJtDCKJfFwFDUIshCt5MgJgPXyJIhHez1BHkgJZMpqHgRwHnn0yyZzL1ayb+3CmLprkVOey3GqcBna6HoX0PhM+mN8ap7AcAkp+P8+BO7AHLjn9gJxuhYNftzLP2dJ+dms7u8xV2S9CtRILpW+H78dR0Sw6bHIf2kiwRkATboNvm8WTim6/pZxEuXu8BNuvFVTIkI9ChijV28h2WhqjGFveS1YIFlg/q9/ncgmjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAQz6hdN/oY2e42o/jNys6kkdajCn3PKkkCWwLawsQA=; b=BulQMjOdlQDIf4lB4yR0HZhsNEqKdiS5jfI7+mHWgzlTApYlM9nYFZhpm0Ue8wdkqI4s3wWkUMLrix5NcXZ6bw6rQ6AXPNiNuNd+oB/JLT8QHCCaOvLrLFoRWhjVnLBPP5gYu5jeCELVryIfNMWnNDAwh4XpFQLdCdRD15uiEqw= Received: from BYAPR18MB2965.namprd18.prod.outlook.com (2603:10b6:a03:10c::30) by BYAPR18MB2805.namprd18.prod.outlook.com (2603:10b6:a03:108::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Mon, 4 Oct 2021 11:13:25 +0000 Received: from BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::75eb:9a16:14b8:2651]) by BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::75eb:9a16:14b8:2651%5]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 11:13:25 +0000 From: Kiran Kumar Kokkilagadda To: Andrew Rybchenko , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram CC: "dev@dpdk.org" , Ori Kam , Thomas Monjalon , Ferruh Yigit , Ivan Malov Thread-Topic: [EXT] [PATCH v1 11/12] net/octeontx2: support ethdev flow action Thread-Index: AQHXtsr0QqBe8prhG0iCpjJzCXkwf6vCs8LA Date: Mon, 4 Oct 2021 11:13:24 +0000 Message-ID: References: <20210907125157.3843-1-ivan.malov@oktetlabs.ru> <20211001134716.1608857-1-andrew.rybchenko@oktetlabs.ru> <20211001134716.1608857-12-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211001134716.1608857-12-andrew.rybchenko@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3a3fd69c-3d46-403f-ff78-08d98727fc10 x-ms-traffictypediagnostic: BYAPR18MB2805: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DP5NHSSpH2h/Ia0JfeNKL7oogcoiuyYRm/fdMK8qCo5UdfcyIE7F4Zq7rA6s1req7oX2X6QKUU1Hp3UQcGmEC6OLIJj1ZHwFC/WGylbV9uqAj34qqM5/dqheMFWotSXTCwjssZG6tROQbyJBQq0Qzlq9laWjt7w9p+K8/T4bzj19pUocEKpIh61jQ6phLxhff8OGE/r3ERVAv3CyX7Byhqflzz/GzS/PDfxe6ChLwgmp8kCl1KUH+mmjpuM7rYMlfdFPx8FXCp+jSgFge0Zdb+4vM8aa88kIThePCZBeENV8cCOdDzzr2zuM74xIRGUUkCEq75ANEY7fPGCznv+pan07kC6QA5NU86AaXfV66e7SIK5Xd28w6TlwGhegsKNoDdOkY8ORuwpLsw6I0cwp0Ox0wa1uFueE93zn87egQ72hFmB2Dtypw4tsi4MljWaXjlMllITDm3d2XzxXIFG/E9sEuvIHoqDCoDAejamfpOjnux/B5Ra9F6BBvO35rLbzXulYGarsJQrEiyOG2SzafUwpGWt0Z5AjAVmaqlSCAPR/FMYQ5HXQfk3VOSxCBsXlSzG0ei0ZspKmS44GFIhsdv0etuRVhCUoM24tyBvRYuHnxvPRgMEr1KGv/PnHcXf5otQR14LTrEI4zXeIU1Qzke7BtUSyfIA4NrxQkd382bzHW13ALADejZzPdqFZL0b2Ul/7m5Fw6ckxW+g8mIQvqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2965.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(83380400001)(76116006)(186003)(2906002)(66446008)(508600001)(33656002)(5660300002)(6506007)(66556008)(64756008)(9686003)(8676002)(52536014)(66946007)(55016002)(66476007)(86362001)(71200400001)(26005)(7696005)(316002)(54906003)(53546011)(122000001)(4326008)(38070700005)(6636002)(38100700002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GK5Y1EMpul+AQX18mZOP5OgGK0+Uva3TLAKD2Qwmhi7ajyGI58C85AY2laDd?= =?us-ascii?Q?3lxpEKWoSPbk54OwrCddetbgVIOsYXPElJj1B/jYyyY6VRkgiNLnHU4oChHW?= =?us-ascii?Q?x9qA9P39Rbz2PD+Tu44oZuacfoW9ywXDfb4nmUcOTJ0GCl8cq3VFHzrHgxU8?= =?us-ascii?Q?k62XyzSTCoYtnNd0V2WQQw5rBfdNpKiz7ifTUwkZ4kD7tNwmJn9+NK8qSS+O?= =?us-ascii?Q?ij6b2og4vzATWSz0WFNUmIlg9heeJTmhTzCrFgUqCwq6L5lBJuZM020cv0Ph?= =?us-ascii?Q?4RaKQKr3f4pLKTtF6Nz5VUNpc6Srjior/TCtTbDnkghs1yRBCtXs77vsf0M+?= =?us-ascii?Q?Oztj1KKFo5h/kEeDZQQlFPM7TkQL5yVW0hUmVRbBqNSz32uZXMjjgQqEXMMB?= =?us-ascii?Q?9uNHijGPfdZ0Ex6fZBhHPC5sc6MI5tdVAo4B6ZPEwZ1RvAxcQ9X3K7RgTm1V?= =?us-ascii?Q?9VWvgmuk+Tzz97OMxkFqO+BZxy2G2V9yuS4P+GIai/potdo4hMoFqiOBZyn8?= =?us-ascii?Q?9p0k0nGr5Zi0nPySEjlB5/jc2LkUyAUH6REM+4PUmbWPVgRTw1iL9+BD3lTa?= =?us-ascii?Q?75WOtNcSOB5HpgE1ehN69alsVV4q593ssR0oKSDFCoqWgmGmxtDjJ+NcZ3lJ?= =?us-ascii?Q?0BpRfGCudIu0v1HSJWK17oPEX2pV0kDJM1dbeokdzqU4CivqXgLbaMELK8Er?= =?us-ascii?Q?Br0nn6VhclbBSZDaJ+WWcxCEdAcvsmijAoWLoySH07BxHvn7Cg+PzuPiVSrP?= =?us-ascii?Q?ZwBcqYmVIMAH34B8DdP4pHL8LSol+stIW/71DWYZ8FUctbD0VO9ptz9HxZM4?= =?us-ascii?Q?W/4uHHSEdHazGhtVxAmGfffx0bRMc30kMl88d+V5C4bbPsDlv/B29sDyxnTr?= =?us-ascii?Q?FABtbLIGWbZZJF+A/L9xTo60G4otfilI/QK3X0/LcwQE3G+UoIPSTDnrVK0C?= =?us-ascii?Q?50+YetBIbOrqfXAD7APd+7/oJDa77hDISSgq8UXiVKJEKuRmIOotKBg/oHCD?= =?us-ascii?Q?ttVNQhDzCbtk7TzbCaNfAOtoqtYn0xRSGZoEQKAY22wfN38Wf3ubymbh2JBJ?= =?us-ascii?Q?m9lxYQ0tB0eKfrB1TCKqHyY8vr/W51GpBjBn8XON6X9BY11PMBbT/qkg9P0Q?= =?us-ascii?Q?cHsmEO1ZjVssZFyKJe72snaUzbDp3r0vM04+f8EMx6bTymFGtmHZMqCmgLqw?= =?us-ascii?Q?zA0uNmztwiagHaqHrDbUjfm2EOLBQGLZZYbaYxEcuI4l+xXRVA0gHfZRBvep?= =?us-ascii?Q?6UJ9MzHe8UP37ILhpsQeFsjOZ31epxGz0wpfYUOgzJ3OVPPozHk5VNf/f0VG?= =?us-ascii?Q?EM17kV+B5TfvV7/opdGzyn9w?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2965.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a3fd69c-3d46-403f-ff78-08d98727fc10 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 11:13:25.0033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4fYzMICXtblrFEr52RsunBq0AVv3gD8qTpFY77YeeEQvv/KCIPHhKQgDfkMGbxAeeAvRx2Ha+kTeKfeNAYqlag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2805 X-Proofpoint-GUID: F7HkU5RMyUP2o0C2u7h6pHds7FF8DdWk X-Proofpoint-ORIG-GUID: F7HkU5RMyUP2o0C2u7h6pHds7FF8DdWk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-04_04,2021-10-04_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 11/12] net/octeontx2: support ethdev flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko > Sent: Friday, October 1, 2021 7:17 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpur= am > ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.org; Ori Kam ; Thomas Monjalon > ; Ferruh Yigit ; Ivan Malov > > Subject: [EXT] [PATCH v1 11/12] net/octeontx2: support ethdev flow action >=20 > External Email >=20 > ---------------------------------------------------------------------- > PORT_ID action implementation works for ingress only and has the same > semantics as ETHDEV action. Please update the documentation also. >=20 > Signed-off-by: Andrew Rybchenko > --- > drivers/net/octeontx2/otx2_flow_parse.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/octeontx2/otx2_flow_parse.c > b/drivers/net/octeontx2/otx2_flow_parse.c > index 63a33142a5..5dd8464ec9 100644 > --- a/drivers/net/octeontx2/otx2_flow_parse.c > +++ b/drivers/net/octeontx2/otx2_flow_parse.c > @@ -900,7 +900,6 @@ otx2_flow_parse_actions(struct rte_eth_dev *dev, { > struct otx2_eth_dev *hw =3D dev->data->dev_private; > struct otx2_npc_flow_info *npc =3D &hw->npc_flow; > - const struct rte_flow_action_port_id *port_act; > const struct rte_flow_action_count *act_count; > const struct rte_flow_action_mark *act_mark; > const struct rte_flow_action_queue *act_q; @@ -987,9 +986,18 @@ > otx2_flow_parse_actions(struct rte_eth_dev *dev, > break; >=20 > case RTE_FLOW_ACTION_TYPE_PORT_ID: > - port_act =3D (const struct rte_flow_action_port_id *) > - actions->conf; > - port_id =3D port_act->id; > + case RTE_FLOW_ACTION_TYPE_ETHDEV: > + if (actions->type =3D=3D > RTE_FLOW_ACTION_TYPE_PORT_ID) { > + const struct rte_flow_action_port_id > *port_act; > + > + port_act =3D actions->conf; > + port_id =3D port_act->id; > + } else { > + const struct rte_flow_action_ethdev > *ethdev_act; > + > + ethdev_act =3D actions->conf; > + port_id =3D ethdev_act->id; > + } > if (rte_eth_dev_get_name_by_port(port_id, if_name)) { > errmsg =3D "Name not found for output port id"; > errcode =3D EINVAL; > -- > 2.30.2