DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pierre Pfister (ppfister)" <ppfister@cisco.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v2] virtio: tx with can_push when VERSION_1 is set
Date: Wed, 30 Nov 2016 09:18:42 +0000	[thread overview]
Message-ID: <C1042323-AA70-46AF-B4D2-24A470ED8DB9@cisco.com> (raw)
In-Reply-To: <6D3BD8A2-1567-42FA-9672-EE682D827A84@cisco.com>

Current virtio driver advertises VERSION_1 support,
but does not handle device's VERSION_1 support when
sending packets (it looks for ANY_LAYOUT feature,
which is absent).

This patch enables 'can_push' in tx path when VERSION_1
is advertised by the device.

This significantly improves small packets forwarding rate
towards devices advertising VERSION_1 feature.

Signed-off-by: Pierre Pfister <ppfister@cisco.com>
---
 drivers/net/virtio/virtio_rxtx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 22d97a4..1e5a6b9 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -1015,7 +1015,8 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 		}
 
 		/* optimize ring usage */
-		if (vtpci_with_feature(hw, VIRTIO_F_ANY_LAYOUT) &&
+		if ((vtpci_with_feature(hw, VIRTIO_F_ANY_LAYOUT) ||
+		      vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) &&
 		    rte_mbuf_refcnt_read(txm) == 1 &&
 		    RTE_MBUF_DIRECT(txm) &&
 		    txm->nb_segs == 1 &&
-- 
2.7.4 (Apple Git-66)

  reply	other threads:[~2016-11-30  9:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  9:31 [dpdk-dev] [PATCH] " Pierre Pfister (ppfister)
2016-11-08  9:44 ` Maxime Coquelin
2016-11-09 12:42   ` Pierre Pfister (ppfister)
2016-11-09 14:42     ` Maxime Coquelin
2016-11-09 14:51     ` Maxime Coquelin
2016-11-22  9:54       ` Pierre Pfister (ppfister)
2016-11-22 13:17         ` Maxime Coquelin
2016-11-30  9:09           ` Pierre Pfister (ppfister)
2016-11-30  9:18             ` Pierre Pfister (ppfister) [this message]
2016-11-30 10:19               ` [dpdk-dev] [PATCH v2] " Yuanhan Liu
2016-12-07  9:42               ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C1042323-AA70-46AF-B4D2-24A470ED8DB9@cisco.com \
    --to=ppfister@cisco.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).