From: Yong Wang <yongwang@vmware.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 4/4] vmxnet3: announce device offload capability
Date: Wed, 13 Jan 2016 02:20:23 +0000 [thread overview]
Message-ID: <C2A3F5A1-E40D-4A14-916D-5D9CB88A062F@vmware.com> (raw)
In-Reply-To: <20160105165205.1945e308@xeon-e3>
On 1/5/16, 4:52 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
>On Tue, 5 Jan 2016 16:12:58 -0800
>Yong Wang <yongwang@vmware.com> wrote:
>
>>
>> /* return 0 means link status changed, -1 means not changed */
>> @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on)
>> else
>> VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid);
>>
>> - /* don't change active filter if in promiscious mode */
>> + /* don't change active filter if in promiscuous mode */
>
>Maybe send a first patch in series with these message and comment cleanups?
>
>Makes the review easier, and aides bisection.
Sure and patch updated.
prev parent reply other threads:[~2016-01-13 2:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 0:12 [dpdk-dev] [PATCH v3 0/4] vmxnet3 TSO and tx cksum offload Yong Wang
2016-01-06 0:12 ` [dpdk-dev] [PATCH v3 1/4] vmxnet3: restore tx data ring support Yong Wang
2016-01-06 0:48 ` Stephen Hemminger
2016-01-13 2:20 ` Yong Wang
2016-01-13 4:50 ` Stephen Hemminger
2016-01-06 0:12 ` [dpdk-dev] [PATCH v3 2/4] vmxnet3: add tx l4 cksum offload Yong Wang
2016-01-06 0:51 ` Stephen Hemminger
2016-01-13 2:20 ` Yong Wang
2016-01-06 0:12 ` [dpdk-dev] [PATCH v3 3/4] vmxnet3: add TSO support Yong Wang
2016-01-06 0:12 ` [dpdk-dev] [PATCH v3 4/4] vmxnet3: announce device offload capability Yong Wang
2016-01-06 0:52 ` Stephen Hemminger
2016-01-13 2:20 ` Yong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2A3F5A1-E40D-4A14-916D-5D9CB88A062F@vmware.com \
--to=yongwang@vmware.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).