From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 81F9E6AB7 for ; Tue, 17 Jun 2014 05:48:59 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 16 Jun 2014 20:49:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,491,1400050800"; d="scan'208";a="558624258" Received: from fmsmsx107.amr.corp.intel.com ([10.19.9.54]) by orsmga002.jf.intel.com with ESMTP; 16 Jun 2014 20:49:14 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX107.amr.corp.intel.com (10.19.9.54) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 16 Jun 2014 20:49:13 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 16 Jun 2014 20:49:13 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.81]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.209]) with mapi id 14.03.0123.003; Tue, 17 Jun 2014 11:48:24 +0800 From: "Xie, Huawei" To: Hiroshi Shimamoto , "dev@dpdk.org" Thread-Topic: [PATCH] rte_memory.h: include stdio.h for FILE Thread-Index: Ac+GFccPmEjnQ1rySKOeKmHBpl3cRQDyM30Q Date: Tue, 17 Jun 2014 03:48:23 +0000 Message-ID: References: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E6A2@BPXM14GP.gisp.nec.co.jp> In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E6A2@BPXM14GP.gisp.nec.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Hayato Momma Subject: Re: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2014 03:49:00 -0000 Hi Shimamoto: At least rte_tailq.h, rte_mbuf.h should also include stdio.h. -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto Sent: Thursday, June 12, 2014 4:11 PM To: dev@dpdk.org Cc: Hayato Momma Subject: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE From: Hiroshi Shimamoto The below commit requires stdio FILE structure. commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188 Author: Stephen Hemminger Date: Fri May 2 16:42:56 2014 -0700 add FILE argument to debug functions Application which includes rte_memory.h without stdio.h will be hit compila= tion failure. /path/to/include/rte_memory.h:146:30: error: unknown type name 'FILE' void rte_dump_physmem_layout(FILE *f); Signed-off-by: Hiroshi Shimamoto Reviewed-by: Hayato Momma --- lib/librte_eal/common/include/rte_memory.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/co= mmon/include/rte_memory.h index 7f21244..4cf8ea9 100644 --- a/lib/librte_eal/common/include/rte_memory.h +++ b/lib/librte_eal/common/include/rte_memory.h @@ -42,6 +42,7 @@ =20 #include #include +#include =20 #ifdef RTE_EXEC_ENV_LINUXAPP #include -- 1.9.1