From: "Xie, Huawei" <huawei.xie@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 5/7] virtio: fix build of debug dump
Date: Thu, 3 Jul 2014 07:17:35 +0000 [thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B0F2270BD@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1404313375-2205-6-git-send-email-thomas.monjalon@6wind.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, July 02, 2014 11:03 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 5/7] virtio: fix build of debug dump
>
> The commit 591a9d7985c1230 (add FILE argument to debug functions) didn't
> compile if CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP is enabled.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
> b/lib/librte_pmd_virtio/virtio_rxtx.c
> index 6d20331..6f02a61 100644
> --- a/lib/librte_pmd_virtio/virtio_rxtx.c
> +++ b/lib/librte_pmd_virtio/virtio_rxtx.c
> @@ -55,7 +55,7 @@
> #include "virtqueue.h"
>
> #ifdef RTE_LIBRTE_VIRTIO_DEBUG_DUMP
> -#define VIRTIO_DUMP_PACKET(m, len) rte_pktmbuf_dump(m, len)
> +#define VIRTIO_DUMP_PACKET(m, len) rte_pktmbuf_dump(stdout, m, len)
> #else
> #define VIRTIO_DUMP_PACKET(m, len) do { } while (0)
> #endif
> --
> 2.0.0
Reviewed-by: Huawei Xie <huawei.xie@intel.com>
next prev parent reply other threads:[~2014-07-03 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 15:02 [dpdk-dev] [PATCH 0/7] build fixes Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 1/7] eal: fix build for bsd Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 2/7] ethdev: fix build of Tx rate limitation debug Thomas Monjalon
2014-07-03 6:36 ` Zhang, Helin
2014-07-02 15:02 ` [dpdk-dev] [PATCH 3/7] ethdev: fix build of named allocation debug Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 4/7] pcap: fix build Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 5/7] virtio: fix build of debug dump Thomas Monjalon
2014-07-03 7:17 ` Xie, Huawei [this message]
2014-07-02 15:02 ` [dpdk-dev] [PATCH 6/7] vmxnet3: fix build with debug Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 7/7] ixgbe/base: " Thomas Monjalon
2014-07-03 6:33 ` Zhang, Helin
2014-07-02 17:57 ` [dpdk-dev] [PATCH 0/7] build fixes Richardson, Bruce
2014-07-02 22:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C37D651A908B024F974696C65296B57B0F2270BD@SHSMSX101.ccr.corp.intel.com \
--to=huawei.xie@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).