From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id C708D30E for ; Thu, 3 Jul 2014 09:17:46 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 03 Jul 2014 00:17:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,593,1400050800"; d="scan'208";a="452811584" Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34]) by azsmga001.ch.intel.com with ESMTP; 03 Jul 2014 00:17:44 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.19.17.221) by FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 3 Jul 2014 00:17:44 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by fmsmsx152.amr.corp.intel.com (10.19.17.221) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 3 Jul 2014 00:17:43 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.81]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.210]) with mapi id 14.03.0123.003; Thu, 3 Jul 2014 15:17:35 +0800 From: "Xie, Huawei" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 5/7] virtio: fix build of debug dump Thread-Index: AQHPlgc7ciEzrYrIdEGPXZORJRhm75uN8RLw Date: Thu, 3 Jul 2014 07:17:35 +0000 Message-ID: References: <1404313375-2205-1-git-send-email-thomas.monjalon@6wind.com> <1404313375-2205-6-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1404313375-2205-6-git-send-email-thomas.monjalon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/7] virtio: fix build of debug dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2014 07:17:47 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, July 02, 2014 11:03 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 5/7] virtio: fix build of debug dump >=20 > The commit 591a9d7985c1230 (add FILE argument to debug functions) didn't > compile if CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP is enabled. >=20 > Signed-off-by: Thomas Monjalon > --- > lib/librte_pmd_virtio/virtio_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c > b/lib/librte_pmd_virtio/virtio_rxtx.c > index 6d20331..6f02a61 100644 > --- a/lib/librte_pmd_virtio/virtio_rxtx.c > +++ b/lib/librte_pmd_virtio/virtio_rxtx.c > @@ -55,7 +55,7 @@ > #include "virtqueue.h" >=20 > #ifdef RTE_LIBRTE_VIRTIO_DEBUG_DUMP > -#define VIRTIO_DUMP_PACKET(m, len) rte_pktmbuf_dump(m, len) > +#define VIRTIO_DUMP_PACKET(m, len) rte_pktmbuf_dump(stdout, m, len) > #else > #define VIRTIO_DUMP_PACKET(m, len) do { } while (0) > #endif > -- > 2.0.0 Reviewed-by: Huawei Xie