DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xie, Huawei" <huawei.xie@intel.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH RFC 0/3] only call iopl when necessary
Date: Wed, 27 Aug 2014 09:22:06 +0000	[thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B0F27CBA6@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1409062300-17004-1-git-send-email-david.marchand@6wind.com>

Hi David:
The reason iopl is put in rte_eal_init is that we want all later created DPDK processes/threads inherit the iopl permission.
If you only call iopl in pmd_init, RX/TX and other threads which needs io permission will segmentation fault.

-huawei

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> Sent: Tuesday, August 26, 2014 10:12 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH RFC 0/3] only call iopl when necessary
> 
> This patch series is just a little clean up to remove the unconditionnal call to
> iopl on linux.
> Rather than call iopl() at the eal level, let the PMD that needs it call
> rte_eal_iopl_init().
> 
> --
> David Marchand
> 
> David Marchand (3):
>   eal/bsd: fix fd leak
>   eal: don't call rte_eal_iopl_init unconditionnally
>   eal: remove unused flags field
> 
>  lib/librte_eal/bsdapp/eal/eal.c         |    6 ++----
>  lib/librte_eal/common/include/rte_eal.h |   17 +++++++++++------
>  lib/librte_eal/linuxapp/eal/eal.c       |   11 ++++-------
>  lib/librte_pmd_virtio/virtio_ethdev.c   |   15 ++++++++-------
>  4 files changed, 25 insertions(+), 24 deletions(-)
> 
> --
> 1.7.10.4

  parent reply	other threads:[~2014-08-27  9:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 14:11 David Marchand
2014-08-26 14:11 ` [dpdk-dev] [PATCH RFC 1/3] eal/bsd: fix fd leak David Marchand
2014-09-25 10:17   ` Thomas Monjalon
2014-08-26 14:11 ` [dpdk-dev] [PATCH RFC 2/3] eal: don't call rte_eal_iopl_init unconditionnally David Marchand
2014-08-27 17:26   ` Xie, Huawei
2014-08-26 14:11 ` [dpdk-dev] [PATCH RFC 3/3] eal: remove unused flags field David Marchand
2014-08-27  9:22 ` Xie, Huawei [this message]
2014-08-27  9:34   ` [dpdk-dev] [PATCH RFC 0/3] only call iopl when necessary David Marchand
2014-08-27  9:57     ` Xie, Huawei
2014-08-27 10:04       ` David Marchand
2014-08-27 10:09         ` Xie, Huawei
2014-08-27 10:24           ` Thomas Monjalon
2014-08-27 21:22   ` Patel, Rashmin N
2014-08-27 22:12     ` Stephen Hemminger
2014-09-29 12:44 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C37D651A908B024F974696C65296B57B0F27CBA6@SHSMSX101.ccr.corp.intel.com \
    --to=huawei.xie@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).