From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 931A358EE for ; Wed, 27 Aug 2014 11:18:28 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 27 Aug 2014 02:14:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,409,1406617200"; d="scan'208";a="582281826" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 27 Aug 2014 02:22:30 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 27 Aug 2014 02:22:30 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 27 Aug 2014 02:22:09 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.198]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0195.001; Wed, 27 Aug 2014 17:22:08 +0800 From: "Xie, Huawei" To: David Marchand , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH RFC 0/3] only call iopl when necessary Thread-Index: AQHPwTf4ruCtCDu990W69LQOSUCEapvkLTnQ Date: Wed, 27 Aug 2014 09:22:06 +0000 Message-ID: References: <1409062300-17004-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1409062300-17004-1-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH RFC 0/3] only call iopl when necessary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 09:18:29 -0000 Hi David: The reason iopl is put in rte_eal_init is that we want all later created DP= DK processes/threads inherit the iopl permission. If you only call iopl in pmd_init, RX/TX and other threads which needs io p= ermission will segmentation fault. -huawei > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > Sent: Tuesday, August 26, 2014 10:12 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH RFC 0/3] only call iopl when necessary >=20 > This patch series is just a little clean up to remove the unconditionnal = call to > iopl on linux. > Rather than call iopl() at the eal level, let the PMD that needs it call > rte_eal_iopl_init(). >=20 > -- > David Marchand >=20 > David Marchand (3): > eal/bsd: fix fd leak > eal: don't call rte_eal_iopl_init unconditionnally > eal: remove unused flags field >=20 > lib/librte_eal/bsdapp/eal/eal.c | 6 ++---- > lib/librte_eal/common/include/rte_eal.h | 17 +++++++++++------ > lib/librte_eal/linuxapp/eal/eal.c | 11 ++++------- > lib/librte_pmd_virtio/virtio_ethdev.c | 15 ++++++++------- > 4 files changed, 25 insertions(+), 24 deletions(-) >=20 > -- > 1.7.10.4