From: "Xie, Huawei" <huawei.xie@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library
Date: Thu, 25 Sep 2014 03:09:32 +0000 [thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B0F2A95D8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <2248333.HL0PhLEb6K@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, September 25, 2014 12:22 AM
> To: Xie, Huawei
> Cc: dev@dpdk.org; Ouyang, Changchun
> Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse
> driver library
>
> Hi,
>
> 2014-09-24 14:32, Ouyang, Changchun:
> > This v4 patch remove the jumbo frame related codes
> > and Huawei will add it back in a separate patch,
>
> I'd prefer a v5 which includes these changes.
> I know this patchset is pending and reworked many times,
> so I'll try to integrate v5 with top priority.
>
> Other comments:
> - examples/vhost/Makefile should not be copied (and removed just after)
> - coding style fixes are aligning things but antislashes are not well aligned
"Anti-slashes alignment" issues are inherited from old code.
There are also hundreds of other serious coding style issues inherited.
I would send a separate patch to fix all those coding style issues after the final
patch. Otherwise if i have to rework the patch, I have to redo the hundreds of style
fixes line by line, which would take too much time, which is very inefficient.
> - fuse-devel and kernel-modules-extra packages are not available in
> this form in all distributions, it's better to describe what is behind
> these package names (especially for kernel-modules-extra)
>
> I won't have time to properly review the big refactoring. But I'm sure
> we'll better check it when using it once integrated.
> The essential is to be able to view the changes in the git history.
> Thanks for this effort.
>
> --
> Thomas
next prev parent reply other threads:[~2014-09-25 3:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:54 Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 1/5] lib/librte_vhost: mv vhost example to vhost lib directory for further code re-factoring Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 2/5] lib/librte_vhost: re-factor vhost lib for subsequent transform Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 3/5] lib/librte_vhost: vhost lib refactor Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 4/5] coding style issue fix Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 5/5] lib/librte_vhost: add vhost lib support in makefile Huawei Xie
2014-09-13 4:57 ` Linhaifeng
2014-09-12 11:07 ` [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library Xie, Huawei
2014-09-23 16:07 ` Xie, Huawei
2014-09-24 14:32 ` Ouyang, Changchun
2014-09-24 16:21 ` Thomas Monjalon
2014-09-25 3:09 ` Xie, Huawei [this message]
2014-09-25 14:27 ` Xie, Huawei
2014-09-25 18:00 ` Xie, Huawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C37D651A908B024F974696C65296B57B0F2A95D8@SHSMSX101.ccr.corp.intel.com \
--to=huawei.xie@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).