From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 41A53B3D7 for ; Thu, 25 Sep 2014 16:21:26 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 25 Sep 2014 07:27:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="391521559" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2014 07:21:22 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 25 Sep 2014 07:27:21 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 25 Sep 2014 07:27:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.230]) with mapi id 14.03.0195.001; Thu, 25 Sep 2014 22:27:19 +0800 From: "Xie, Huawei" To: "Xie, Huawei" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library Thread-Index: AQHP2BPH5Oo9GUVA5U+wfUsTECrFL5wRKT/AgAC+ZwA= Date: Thu, 25 Sep 2014 14:27:18 +0000 Message-ID: References: <1410519304-14521-1-git-send-email-huawei.xie@intel.com> <2248333.HL0PhLEb6K@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2014 14:21:27 -0000 I am preparing v5 patch for vhost lib and vhost example, merging the merge-= able=20 feature. The weird thing is merge-able feature ever works smoothly in my ol= d code base which is based on 1.7.1, while after I merge with latest repo, mergeable could cause mbuf all= ocation failure. I did code comparison of vhost example and lib, the only change is the mbuf= change. Debugging the issue. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xie, Huawei > Sent: Thursday, September 25, 2014 11:10 AM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost= cuse > driver library >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, September 25, 2014 12:22 AM > > To: Xie, Huawei > > Cc: dev@dpdk.org; Ouyang, Changchun > > Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vho= st cuse > > driver library > > > > Hi, > > > > 2014-09-24 14:32, Ouyang, Changchun: > > > This v4 patch remove the jumbo frame related codes > > > and Huawei will add it back in a separate patch, > > > > I'd prefer a v5 which includes these changes. > > I know this patchset is pending and reworked many times, > > so I'll try to integrate v5 with top priority. > > > > Other comments: > > - examples/vhost/Makefile should not be copied (and removed just after) > > - coding style fixes are aligning things but antislashes are not well a= ligned >=20 > "Anti-slashes alignment" issues are inherited from old code. > There are also hundreds of other serious coding style issues inherited. > I would send a separate patch to fix all those coding style issues after = the final > patch. Otherwise if i have to rework the patch, I have to redo the hundre= ds of > style > fixes line by line, which would take too much time, which is very ineffic= ient. >=20 >=20 > > - fuse-devel and kernel-modules-extra packages are not available in > > this form in all distributions, it's better to describe what is behin= d > > these package names (especially for kernel-modules-extra) > > > > I won't have time to properly review the big refactoring. But I'm sure > > we'll better check it when using it once integrated. > > The essential is to be able to view the changes in the git history. > > Thanks for this effort. > > > > -- > > Thomas