From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 13D3C7E61 for ; Thu, 25 Sep 2014 19:56:54 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 25 Sep 2014 11:03:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,598,1406617200"; d="scan'208";a="608634732" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 25 Sep 2014 11:00:40 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 25 Sep 2014 11:00:40 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0195.001; Fri, 26 Sep 2014 02:00:38 +0800 From: "Xie, Huawei" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library Thread-Index: AQHP2BPH5Oo9GUVA5U+wfUsTECrFL5wRKT/AgAC+ZwCAAC+XMA== Date: Thu, 25 Sep 2014 18:00:37 +0000 Message-ID: References: <1410519304-14521-1-git-send-email-huawei.xie@intel.com> <2248333.HL0PhLEb6K@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2014 17:56:55 -0000 I turned off CONFIG_RTE_IXGBE_INC_VEC, everything works fine.=20 > -----Original Message----- > From: Xie, Huawei > Sent: Thursday, September 25, 2014 10:27 PM > To: Xie, Huawei; Thomas Monjalon > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost= cuse > driver library >=20 > I am preparing v5 patch for vhost lib and vhost example, merging the merg= e- > able > feature. The weird thing is merge-able feature ever works smoothly in my = old > code base which is based on > 1.7.1, while after I merge with latest repo, mergeable could cause mbuf > allocation failure. > I did code comparison of vhost example and lib, the only change is the mb= uf > change. > Debugging the issue. >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xie, Huawei > > Sent: Thursday, September 25, 2014 11:10 AM > > To: Thomas Monjalon > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vho= st cuse > > driver library > > > > > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Thursday, September 25, 2014 12:22 AM > > > To: Xie, Huawei > > > Cc: dev@dpdk.org; Ouyang, Changchun > > > Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space v= host > cuse > > > driver library > > > > > > Hi, > > > > > > 2014-09-24 14:32, Ouyang, Changchun: > > > > This v4 patch remove the jumbo frame related codes > > > > and Huawei will add it back in a separate patch, > > > > > > I'd prefer a v5 which includes these changes. > > > I know this patchset is pending and reworked many times, > > > so I'll try to integrate v5 with top priority. > > > > > > Other comments: > > > - examples/vhost/Makefile should not be copied (and removed just afte= r) > > > - coding style fixes are aligning things but antislashes are not well= aligned > > > > "Anti-slashes alignment" issues are inherited from old code. > > There are also hundreds of other serious coding style issues inherited. > > I would send a separate patch to fix all those coding style issues afte= r the final > > patch. Otherwise if i have to rework the patch, I have to redo the hund= reds of > > style > > fixes line by line, which would take too much time, which is very ineff= icient. > > > > > > > - fuse-devel and kernel-modules-extra packages are not available in > > > this form in all distributions, it's better to describe what is beh= ind > > > these package names (especially for kernel-modules-extra) > > > > > > I won't have time to properly review the big refactoring. But I'm sur= e > > > we'll better check it when using it once integrated. > > > The essential is to be able to view the changes in the git history. > > > Thanks for this effort. > > > > > > -- > > > Thomas