From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 71E625918 for ; Mon, 13 Oct 2014 22:46:12 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 13 Oct 2014 13:43:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,713,1406617200"; d="scan'208";a="604721854" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2014 13:53:37 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 13 Oct 2014 13:53:37 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.230]) with mapi id 14.03.0195.001; Tue, 14 Oct 2014 04:53:35 +0800 From: "Xie, Huawei" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 00/25] user space vhost library Thread-Index: AQHP5x8fhE3draCLWU+gBWTx6F15bpwufvYw Date: Mon, 13 Oct 2014 20:53:34 +0000 Message-ID: References: <1412794499-4332-1-git-send-email-huawei.xie@intel.com> <4458709.TeG1xlHSS8@xps13> In-Reply-To: <4458709.TeG1xlHSS8@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 00/25] user space vhost library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2014 20:46:12 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, October 13, 2014 12:52 PM > To: Xie, Huawei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 00/25] user space vhost library >=20 > Hi Huawei, >=20 > 2014-10-09 02:54, Huawei Xie: > > This set of patches transforms and refactors vhost example to a user > > space vhost library. > > This library implements a user space vhost cuse driver, and provides > > generic APIs for user space ethernet vSwitch to integrate us-vhost for > > fast packet switching with guest virtio. > > > > vhost lib consists of five APIs plus several helper routines > > for feature disable/enable. > > 1) rte_vhost_driver_register initializes vhost driver. > > 2) rte_vhost_driver_callback_register registers the callbacks. > > Callbacks are called from vhost driver when a virtio device is ready > > to be added to the data processing core or is de-activated by guest. > > 3) rte_vhost_driver_session_start, a blocking API to start vhost > > message handler session loop. > > 4) rte_vhost_enqueue_burst and rte_vhost_dequeue_burst for > > enqueue/dequeue packets to/from virtio ring respectively. > > > > v2) turn off vhost lib by default > > > > v3) fixed checkpatch issues > > > > v4) split the patch per thomas' requirement > > > > v5) fine granularity split of the patch > > regenerate patches based on latest commit > > this patchset removes vhost example patches, which will be > > submitted later. > > > > Huawei Xie (25): > > move src files from examples/vhost to lib/librte_vhost > > rename main.c to vhost_rxtx.c and virtio-net.h to rte_vhost_net.h > > keep virtio_dev_(merge_)rx, copy_from_mbuf_to_vring and > virtio_dev_merge_tx; remove anything else in vhost_rxtx.c > > remove mac learning, mac/vlan, VMDQ and other switching related logic > > remove host memory region region related logic > > remove retry > > patch virtio_dev_merge_tx to make it return packets to app > > patch vhost_dev_merge_tx about buf_size > > add queue_id parameter to vhost rx/tx functions > > define PACKET_BURST > > rte_vhost_en/dequeue_burst API > > move virtio_net_config_ll strcture to virtio_net.c > > remove index > > call get_virtio_net_callbacks to get the ops in register_cuse_device > > rte_vhost_driver_register and rte_vhost_session_start API > > rte_vhost_callback_register API > > add debug print > > define VHOST_SUPPORTED_FEATURES > > header file cleanup > > static fix > > add priv field in virtio_net to store application specific context > > coding style fixes > > add TODO/FIXME > > add vhost support in Makefile >=20 > Thanks for your hard work. > There are still few things to clean in this patch splitting > but I've did it to apply them. > I won't describe all the changes I've done, you can check them in the > git repository. In short, some split or merge were needed, some lines wer= e > removed and re-added later, build dependencies were not correct and doc > generation was missing. > You did the big work by really splitting all these stuff. Working on smal= l > commits was far easier. Thanks >=20 > Applied >=20 > Now you can add the new example. > I hope we'll have more reviews and cleanup now that the first version of > this library is integrated. Thanks! Would check and submit the example patch soon. Yes, this is the=20 first step, next we would have code cleanup, bug fix, performance tuning,=20 interfaces refine, new qemu us-vhost support, etc. >=20 > -- > Thomas