From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E95367E7A for ; Fri, 17 Oct 2014 05:12:15 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 16 Oct 2014 20:20:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,736,1406617200"; d="scan'208";a="615890006" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 16 Oct 2014 20:19:51 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 16 Oct 2014 20:19:51 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 16 Oct 2014 20:19:50 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.230]) with mapi id 14.03.0195.001; Fri, 17 Oct 2014 11:19:46 +0800 From: "Xie, Huawei" To: "Ouyang, Changchun" , Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [PATCH] vhost: Fix the vhost broken issue Thread-Index: AQHP5rjhrquA8OtN5U2rZj68b+57FZwtpKMggAPlyGCAAhV6IIAABHiQ Date: Fri, 17 Oct 2014 03:19:45 +0000 Message-ID: References: <1413185980-17348-1-git-send-email-changchun.ouyang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: Fix the vhost broken issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2014 03:12:16 -0000 Thomas: Thoughts about this? Could I send example patch with this walk around? > -----Original Message----- > From: Ouyang, Changchun > Sent: Thursday, October 16, 2014 8:15 PM > To: Xie, Huawei; Thomas Monjalon; dev@dpdk.org > Cc: Cao, Waterman; Richardson, Bruce; Ouyang, Changchun > Subject: RE: [PATCH] vhost: Fix the vhost broken issue >=20 > No problem, I will investigate the root cause. >=20 > But before figuring out the root cause, I think we could add check in you= r new > sample to > Check the INC_VEC is enable or not, If it is enabled, print error message= and hint > user > Disable it in config file if mergeable feature is triggered in vhost. The= n this issue > should not > block you from sending out your vhost app patch. >=20 > Your vhost app patch will block my another patch about multicast feature = as > your vhost lib patch delete the vhost sample app totally. > So expect your vhost app patch send out soon. >=20 > Thanks and regards, > Changchun >=20 >=20 > -----Original Message----- > From: Xie, Huawei > Sent: Thursday, October 16, 2014 3:20 AM > To: Ouyang, Changchun; Thomas Monjalon; dev@dpdk.org > Cc: Cao, Waterman; Richardson, Bruce > Subject: RE: [PATCH] vhost: Fix the vhost broken issue >=20 > I generated the vhost example patch based on vhost library, but find ther= e is > issue with --mergeable feature. > Only thousands of packets could be sent. > Then I tried the latest vhost example, which is just before my vhost lib= patch, I > found that not only it has the issue Which is fixed by the following patc= h but the > --mergeable feature also doesn't work. > Haven't got the change to dig into it. >=20 > Hints here: > 1. mbuf allocation failure after thousands of packets. > 2. disable INC_VEC(vectore scatter receive) in configure could solve this= . > 3. tried sending the packets directly out after receiving from vmdq queue= , it > works. >=20 > Could you root cause the issue, Changchun? You could work on the most rec= ent > example. >=20 > > -----Original Message----- > > From: Ouyang, Changchun > > Sent: Monday, October 13, 2014 12:48 AM > > To: Thomas Monjalon; dev@dpdk.org > > Cc: Xie, Huawei; Cao, Waterman; Ouyang, Changchun > > Subject: RE: [PATCH] vhost: Fix the vhost broken issue > > > > Hi Thomas, > > > > If HuaweiXie's patch set for vhost library and new vhost sample could > > be applied into dpdk.org very soon, Then this patch could be > > depressed/superseded, I think his patch can fix this issue. > > Otherwise, this patch could be high priority as the vhost is broken in > > the tip code due to recent commit related to mbuf change. > > > > Thanks and regards, > > Changchun > > > > > -----Original Message----- > > > From: Ouyang, Changchun > > > Sent: Monday, October 13, 2014 3:40 PM > > > To: dev@dpdk.org > > > Cc: Cao, Waterman; Ouyang, Changchun > > > Subject: [PATCH] vhost: Fix the vhost broken issue > > > > > > As the vhost sample is broken by the following commit, > > > commit 08b563ffb19d8baf59dd84200f25bc85031d18a7 > > > Author: Olivier Matz > > > Date: Thu Sep 11 14:15:35 2014 +0100 > > > mbuf: replace data pointer by an offset > > > > > > It leads to segment fault error in vhost when binding a virtio > > > device MAC address to its corresponding VMDq pool by executing > > > command line 'start tx- first' in test-pmd on guest. > > > > > > This patch fixes that issue. > > > > > > Signed-off-by: Changchun Ouyang > > > --- > > > examples/vhost/main.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c index > > > 9cf8e20..a6db607 100644 > > > --- a/examples/vhost/main.c > > > +++ b/examples/vhost/main.c > > > @@ -1782,6 +1782,7 @@ virtio_dev_tx(struct virtio_net* dev, struct > > > rte_mempool *mbuf_pool) > > > /* Setup dummy mbuf. This is copied to a real mbuf if > transmitted > > > out the physical port. */ > > > m.data_len =3D desc->len; > > > m.pkt_len =3D desc->len; > > > + m.buf_addr =3D (void *)(uintptr_t)buff_addr; > > > m.data_off =3D 0; > > > > > > PRINT_PACKET(dev, (uintptr_t)buff_addr, desc->len, 0); > > > -- > > > 1.8.4.2