From: "Xie, Huawei" <huawei.xie@intel.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and vector pmd
Date: Thu, 30 Oct 2014 06:16:33 +0000 [thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B0F2D893E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1414635076-3267-1-git-send-email-changchun.ouyang@intel.com>
Acked-by Huawei Xie <huawei.xie@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ouyang Changchun
> Sent: Wednesday, October 29, 2014 7:11 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and
> vector pmd
>
> Since the commit 33e79bed3edc2bcf59 has fixed the issue in vector PMD,
> and then it can receive jumbo frame by scatter-gather mode, so remove this
> check.
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
> examples/vhost/main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 291128e..57ef464 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -2863,13 +2863,6 @@ MAIN(int argc, char *argv[])
> ret = us_vhost_parse_args(argc, argv);
> if (ret < 0)
> rte_exit(EXIT_FAILURE, "Invalid argument\n");
> -#ifdef RTE_IXGBE_INC_VECTOR
> - if (mergeable == 1) {
> - rte_exit(EXIT_FAILURE,
> - "sorry, mergeable feature doesn't work with vec sg recv,
> " \
> - "please disable it in cfg as a workaround\n");
> - }
> -#endif
>
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id ++)
> if (rte_lcore_is_enabled(lcore_id))
> --
> 1.8.4.2
next prev parent reply other threads:[~2014-10-30 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 2:11 Ouyang Changchun
2014-10-30 6:16 ` Xie, Huawei [this message]
2014-10-30 8:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C37D651A908B024F974696C65296B57B0F2D893E@SHSMSX101.ccr.corp.intel.com \
--to=huawei.xie@intel.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).