* [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and vector pmd
@ 2014-10-30 2:11 Ouyang Changchun
2014-10-30 6:16 ` Xie, Huawei
0 siblings, 1 reply; 3+ messages in thread
From: Ouyang Changchun @ 2014-10-30 2:11 UTC (permalink / raw)
To: dev
Since the commit 33e79bed3edc2bcf59 has fixed the issue in vector PMD,
and then it can receive jumbo frame by scatter-gather mode, so remove this check.
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
examples/vhost/main.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 291128e..57ef464 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -2863,13 +2863,6 @@ MAIN(int argc, char *argv[])
ret = us_vhost_parse_args(argc, argv);
if (ret < 0)
rte_exit(EXIT_FAILURE, "Invalid argument\n");
-#ifdef RTE_IXGBE_INC_VECTOR
- if (mergeable == 1) {
- rte_exit(EXIT_FAILURE,
- "sorry, mergeable feature doesn't work with vec sg recv, " \
- "please disable it in cfg as a workaround\n");
- }
-#endif
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id ++)
if (rte_lcore_is_enabled(lcore_id))
--
1.8.4.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and vector pmd
2014-10-30 2:11 [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and vector pmd Ouyang Changchun
@ 2014-10-30 6:16 ` Xie, Huawei
2014-10-30 8:40 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Xie, Huawei @ 2014-10-30 6:16 UTC (permalink / raw)
To: Ouyang, Changchun, dev
Acked-by Huawei Xie <huawei.xie@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ouyang Changchun
> Sent: Wednesday, October 29, 2014 7:11 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and
> vector pmd
>
> Since the commit 33e79bed3edc2bcf59 has fixed the issue in vector PMD,
> and then it can receive jumbo frame by scatter-gather mode, so remove this
> check.
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
> examples/vhost/main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 291128e..57ef464 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -2863,13 +2863,6 @@ MAIN(int argc, char *argv[])
> ret = us_vhost_parse_args(argc, argv);
> if (ret < 0)
> rte_exit(EXIT_FAILURE, "Invalid argument\n");
> -#ifdef RTE_IXGBE_INC_VECTOR
> - if (mergeable == 1) {
> - rte_exit(EXIT_FAILURE,
> - "sorry, mergeable feature doesn't work with vec sg recv,
> " \
> - "please disable it in cfg as a workaround\n");
> - }
> -#endif
>
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id ++)
> if (rte_lcore_is_enabled(lcore_id))
> --
> 1.8.4.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and vector pmd
2014-10-30 6:16 ` Xie, Huawei
@ 2014-10-30 8:40 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-10-30 8:40 UTC (permalink / raw)
To: dev, Ouyang, Changchun
> From: Ouyang Changchun
> > Since the commit 33e79bed3edc2bcf59 has fixed the issue in vector PMD,
> > and then it can receive jumbo frame by scatter-gather mode, so remove this
> > check.
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
>
> Acked-by: Huawei Xie <huawei.xie@intel.com>
Applied
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-30 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-30 2:11 [dpdk-dev] [PATCH] vhost: Remove the check between mergeable and vector pmd Ouyang Changchun
2014-10-30 6:16 ` Xie, Huawei
2014-10-30 8:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).