From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 888E45947 for ; Wed, 5 Nov 2014 22:46:09 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 05 Nov 2014 13:55:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,322,1413270000"; d="scan'208";a="627256784" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga002.fm.intel.com with ESMTP; 05 Nov 2014 13:55:31 -0800 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 05:55:30 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 05:55:29 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0195.001; Thu, 6 Nov 2014 05:55:28 +0800 From: "Xie, Huawei" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes Thread-Index: AQHP+TjrByqqi8kMbU2eUD4O0uH1bJxSiS2Q//98QYCAAIyQoA== Date: Wed, 5 Nov 2014 21:55:28 +0000 Message-ID: References: <1415206995-1086-1-git-send-email-huawei.xie@intel.com> <6180706.cUEATDuu1O@xps13> <2088055.shkfIhmk6J@xps13> In-Reply-To: <2088055.shkfIhmk6J@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 21:46:10 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, November 05, 2014 2:25 PM > To: Xie, Huawei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes >=20 > 2014-11-05 21:21, Xie, Huawei: > > Thomas: > > I checked before. checkpatch reports 9 warnings, "over 80 characters" = and > "prefer pr_deubg". > > This code style fixes code style issue only, not the pr_debug/printk is= sue. > Thoughts? >=20 > Using pr_debug is a code style fix. >=20 Ok, will also fix this. If there are other code style issue you want to be fixed in this patch, ple= ase let me know. Btw, for alignment in structure, I see different projects use different wa= y, some use tab, and some use space(between type and var), do we have rules= for this? { Type var1 Type var2 } > > Besides, I don't understand the MISORDERED_TYPE. >=20 > You should replace (long long unsigned) by (unsigned long long). Check patch at my side doesn't report warnings about the patch. I remember = I have also check against the source file. Will double check and fix those. >=20 > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Wednesday, November 05, 2014 1:42 PM > > > To: Xie, Huawei > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes > > > > > > Hi Huawei, > > > > > > checkpatch.pl reports some errors of types PREFER_PR_LEVEL > > > and MISORDERED_TYPE. > > > > > > -- > > > Thomas