From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DC10E7F74 for ; Thu, 6 Nov 2014 01:16:16 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 05 Nov 2014 16:23:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,322,1413270000"; d="scan'208";a="603122694" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 05 Nov 2014 16:25:40 -0800 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 08:22:44 +0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 08:22:43 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0195.001; Thu, 6 Nov 2014 08:22:42 +0800 From: "Xie, Huawei" To: "dev@dpdk.org" Thread-Topic: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix Thread-Index: AQHP2t/7PNrEWkHFdU6oB5A1OXl2AZxS+WbA Date: Thu, 6 Nov 2014 00:22:42 +0000 Message-ID: References: <1411883352-22166-1-git-send-email-huawei.xie@intel.com> In-Reply-To: <1411883352-22166-1-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 00:16:17 -0000 Thomas, comments for this patch? > -----Original Message----- > From: Xie, Huawei > Sent: Saturday, September 27, 2014 10:49 PM > To: dev@dpdk.org > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix >=20 > the right shift bits should be 5 rather than 4. > vid_idx =3D (uint32_t) ((vlan_id >> 5 ) & 0x7F) >=20 > Signed-off-by: Huawei Xie > CC: Jing Chen > CC: Helin Zhang >=20 > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index 9009bd4..9c9d831 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, > { > uint32_t vid_idx, vid_bit; >=20 > -#define UINT32_BIT_MASK 0x1F > -#define VALID_VLAN_BIT_MASK 0xFFF > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find= the > * element first, then find the bits it belongs to > */ > - vid_idx =3D (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > - sizeof(uint32_t)); > - vid_bit =3D (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > + vid_idx =3D (uint32_t) ((vlan_id >> 5 ) & 0x7F); > + vid_bit =3D (uint32_t) (1 << (vlan_id & 0x1F)); >=20 > if (on) > vsi->vfta[vid_idx] |=3D vid_bit; > -- > 1.8.1.4