DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xie, Huawei" <huawei.xie@intel.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue
Date: Thu, 6 Nov 2014 02:38:31 +0000	[thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B0F2E28C3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1415002313-15661-1-git-send-email-changchun.ouyang@intel.com>

>  		path = realpath(memfile, resolved_path);
> -		if (path == NULL) {
> +		if ((path == NULL) && (strlen(resolved_path) == 0)) {
>  			RTE_LOG(ERR, VHOST_CONFIG,
>  				"(%"PRIu64") Failed to resolve fd directory\n",
>  				dev->device_fh);
Changchun:
For some strange file, according to API description, we shouldn't check resolved_path as it is undefined.
To make the loop go on, we could use "continue" when we detect path is NULL.

RETURN VALUE
       If there is no error, realpath() returns a pointer to the resolved_path.

       Otherwise it returns a NULL pointer, and the contents of the array resolved_path are undefined, and errno is set to indicate the error.

  reply	other threads:[~2014-11-06  2:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03  8:11 Ouyang Changchun
2014-11-06  2:38 ` Xie, Huawei [this message]
2014-11-06  5:20   ` Ouyang, Changchun
2014-11-06 20:47     ` Xie, Huawei
2014-11-06 20:53 ` Xie, Huawei
2014-11-06 22:13   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C37D651A908B024F974696C65296B57B0F2E28C3@SHSMSX101.ccr.corp.intel.com \
    --to=huawei.xie@intel.com \
    --cc=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).