From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D4EAA7EC4 for ; Thu, 6 Nov 2014 21:44:07 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 06 Nov 2014 12:47:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="412635157" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by FMSMGA003.fm.intel.com with ESMTP; 06 Nov 2014 12:44:54 -0800 Received: from kmsmsx152.gar.corp.intel.com (172.21.73.87) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 7 Nov 2014 04:53:17 +0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 7 Nov 2014 04:53:16 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by shsmsx102.ccr.corp.intel.com ([169.254.2.156]) with mapi id 14.03.0195.001; Fri, 7 Nov 2014 04:53:15 +0800 From: "Xie, Huawei" To: "Ouyang, Changchun" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue Thread-Index: AQHP9z5ZPyMYv+0Ta06WGuZbD1h80pxUGL9A Date: Thu, 6 Nov 2014 20:53:15 +0000 Message-ID: References: <1415002313-15661-1-git-send-email-changchun.ouyang@intel.com> In-Reply-To: <1415002313-15661-1-git-send-email-changchun.ouyang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 20:44:08 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ouyang Changchun > Sent: Monday, November 03, 2014 1:12 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue >=20 > Commit aec8283d47d4e4366b6 fixes the compilation issue, but it leads to > one runtime issue: early exit wrongly. In some case, 'path' is NULL, but > 'resolved_path' has effective path, it should continue going ahead rather > than exit. >=20 > Signed-off-by: Changchun Ouyang > --- > lib/librte_vhost/virtio-net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.= c > index 8015dd8..3fa1274 100644 > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -237,7 +237,7 @@ host_memory_map(struct virtio_net *dev, struct > virtio_memory *mem, > snprintf(memfile, PATH_MAX, "/proc/%u/fd/%s", > pid, dptr->d_name); > path =3D realpath(memfile, resolved_path); > - if (path =3D=3D NULL) { > + if ((path =3D=3D NULL) && (strlen(resolved_path) =3D=3D 0)) { > RTE_LOG(ERR, VHOST_CONFIG, > "(%"PRIu64") Failed to resolve fd directory\n", > dev->device_fh); > -- > 1.8.4.2 Acked-by: Huawei Xie