From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8A8BC5AB5 for ; Fri, 23 Jan 2015 04:21:39 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 22 Jan 2015 19:21:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,453,1418112000"; d="scan'208";a="641376143" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by orsmga001.jf.intel.com with ESMTP; 22 Jan 2015 19:21:35 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 23 Jan 2015 11:20:32 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0195.001; Fri, 23 Jan 2015 11:20:28 +0800 From: "Xie, Huawei" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature Thread-Index: AQHP8ZiWaTe6iUB4qUqeWNzwnR/mzZy2cCoggAlXTQCADcuekA== Date: Fri, 23 Jan 2015 03:20:28 +0000 Message-ID: References: <1408932572-10343-1-git-send-email-changchun.ouyang@intel.com> <1414381533-30370-4-git-send-email-changchun.ouyang@intel.com> <3392599.aeVbzi96HQ@xps13> In-Reply-To: <3392599.aeVbzi96HQ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 03:21:40 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, January 15, 2015 12:37 AM > To: dev@dpdk.org > Cc: Xie, Huawei; Ouyang, Changchun > Subject: Re: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and con= fig > VMDQ offload register for multicast feature >=20 > Hi Huawei, >=20 > 2015-01-08 10:07, Xie, Huawei: > > CTRL_RX is dependent on CTRL_VQ. > > CTRL_VQ should be enabled if CTRL_RX is enabled. > > Observed that virtio-net driver will crash if CTRL_VQ isn't enabled in = vhost-user > case. > > /* Caller should know better */ > > BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ) || > > (out + in > VIRTNET_SEND_COMMAND_SG_MAX)); >=20 > Do you plan to send a patch? In the vhost-user patch, will temporarily turn this on. However, we don't create any control queues in vhost. Will investigate the root cause later. >=20 > -- > Thomas