From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 51BEB5AC3 for ; Fri, 23 Jan 2015 04:40:49 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 22 Jan 2015 19:37:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,453,1418112000"; d="scan'208";a="674558383" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga002.jf.intel.com with ESMTP; 22 Jan 2015 19:40:47 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 23 Jan 2015 11:40:43 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.173]) with mapi id 14.03.0195.001; Fri, 23 Jan 2015 11:40:42 +0800 From: "Xie, Huawei" To: Linhaifeng , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support Thread-Index: AQHQFQSPuj2ODw/mVUO8Nw87MDVwrZzNUZaw Date: Fri, 23 Jan 2015 03:40:41 +0000 Message-ID: References: <1418247477-13920-1-git-send-email-huawei.xie@intel.com> <1418247477-13920-9-git-send-email-huawei.xie@intel.com> <54892D4D.3060708@huawei.com> In-Reply-To: <54892D4D.3060708@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 03:40:49 -0000 > -----Original Message----- > From: Linhaifeng [mailto:haifeng.lin@huawei.com] > Sent: Thursday, December 11, 2014 1:36 PM > To: Xie, Huawei; dev@dpdk.org > Cc: haifeng.lin@intel.com > Subject: Re: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user > support >=20 >=20 >=20 > On 2014/12/11 5:37, Huawei Xie wrote: > > vhost-user support > > > > > > Signed-off-by: Huawei Xie > > --- > > lib/librte_vhost/Makefile | 5 +- > > + case VHOST_USER_SET_LOG_FD: >=20 > should close fd for fd leak when receive VHOST_USER_SET_LOG_FD msg? Ok, would at least close the fd though we don't support. Do you know how to test this? >=20 > > + RTE_LOG(INFO, VHOST_CONFIG, "not implemented.\n"); > > + > > + case VHOST_USER_SET_VRING_ERR: >=20 > should close fd for fd leak? Would do. >=20 > > + RTE_LOG(INFO, VHOST_CONFIG, "not implemented\n"); > > + break; > > +#endif > > >=20 > -- > Regards, > Haifeng