From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AA1B95A7C for ; Thu, 29 Jan 2015 14:00:50 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 29 Jan 2015 05:00:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,485,1418112000"; d="scan'208";a="658592202" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by fmsmga001.fm.intel.com with ESMTP; 29 Jan 2015 05:00:47 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 29 Jan 2015 21:00:30 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.253]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.231]) with mapi id 14.03.0195.001; Thu, 29 Jan 2015 21:00:27 +0800 From: "Xie, Huawei" To: Linhaifeng , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is no buffer Thread-Index: AQHQO67GgUqVMnSI5EeHUDiC/owWhZzW5y3g//+ciACAAInAcA== Date: Thu, 29 Jan 2015 13:00:27 +0000 Message-ID: References: <1422527404-12424-1-git-send-email-haifeng.lin@huawei.com> <54CA29F4.8080108@huawei.com> In-Reply-To: <54CA29F4.8080108@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is no buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 13:00:51 -0000 > -----Original Message----- > From: Linhaifeng [mailto:haifeng.lin@huawei.com] > Sent: Thursday, January 29, 2015 8:39 PM > To: Xie, Huawei; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer when t= here is > no buffer >=20 >=20 >=20 > On 2015/1/29 18:39, Xie, Huawei wrote: >=20 > >> - if (count =3D=3D 0) > >> + /* If there is no buffers we should notify guest to fill. > >> + * This is need when guest use virtio_net driver(not pmd). > >> + */ > >> + if (count =3D=3D 0) { > >> + if (!(vq->avail->flags & > >> VRING_AVAIL_F_NO_INTERRUPT)) > >> + eventfd_write((int)vq->kickfd, 1); > >> return 0; > >> + } > > > > Haifeng: > > Is it the root cause and is it protocol required? > > Could you give a detailed description for that scenario? > > >=20 > I use mz to send data from one VM1 to VM2.The two VM use virtio-net drive= r. > VM1 execute follow script: > for((i=3D0;i<999999999;i++)); > do > mz eth0 -t udp -A 1.1.1.1 -B 1.1.1.2 -a 00:00:00:00:00:01 -b 00:00:00:00:= 00:02 -c > 10000000 -p 512 > sleep 4 > done >=20 > VM2 execute follow command to watch: > watch -d ifconfig >=20 > After many hours VM2 stop to receive data. >=20 > Could you test it ? We could try next week after I send the whole patch.=20 How many hours? Is it reproducible at your side? I inject packets through p= acket generator to guest for more than ten hours, haven't met issues.=20 As I said in another mail sent to you, could you dump the status of vring = if you still have the spot? Could you please also reply to that mail? For the patch, if we have no root cause, I prefer not to apply it, so that = we don't send more interrupts than needed to guest to affect performance. People could temporarily apply this patch as a work around. Or anyone=20 > -- > Regards, > Haifeng