From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CAA055A7C for ; Sat, 31 Jan 2015 16:16:53 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 31 Jan 2015 07:16:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,497,1418112000"; d="scan'208";a="520684421" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga003.jf.intel.com with ESMTP; 31 Jan 2015 07:09:28 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Sat, 31 Jan 2015 23:16:49 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.253]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.91]) with mapi id 14.03.0195.001; Sat, 31 Jan 2015 23:16:49 +0800 From: "Xie, Huawei" To: Tetsuya Mukawa , "dev@dpdk.org" Thread-Topic: [PATCH 05/12] lib/librte_vhost: copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c Thread-Index: AQHQPHQ0ZvTI4rDR70SbOkwRUM+ElZzaWDFg Date: Sat, 31 Jan 2015 15:16:48 +0000 Message-ID: References: <1422599787-12009-1-git-send-email-huawei.xie@intel.com> <1422599787-12009-6-git-send-email-huawei.xie@intel.com> <54CB572B.4040409@igel.co.jp> In-Reply-To: <54CB572B.4040409@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 05/12] lib/librte_vhost: copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jan 2015 15:16:54 -0000 > > + * map it to our address space. > > + */ > > +static int > > +host_memory_map(struct virtio_net *dev, struct virtio_memory *mem, > > + pid_t pid, uint64_t addr) > > +{ >=20 > Hi Xie, >=20 > This patch only copy host_memory_map() to a new file. > And actually the original function is removed at below patch. > - "[PATCH 07/12] lib/librte_vhost: split set_memory_table into two parts" >=20 > Is it difficult to remove and copy the function in this patch? The purpose of splitting into several patches is to be reviewer friendly. You could easily check the changes between each commit. >=20 > Thanks, > Tetsuya >=20