From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D60CA5A81
 for <dev@dpdk.org>; Sat, 31 Jan 2015 16:24:30 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 31 Jan 2015 07:24:08 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="448020861"
Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91])
 by FMSMGA003.fm.intel.com with ESMTP; 31 Jan 2015 07:10:10 -0800
Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by
 PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Sat, 31 Jan 2015 23:24:06 +0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Sat, 31 Jan 2015 23:24:05 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.253]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0195.001;
 Sat, 31 Jan 2015 23:24:05 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Linhaifeng <haifeng.lin@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [RFC PATCH v2 01/14] enable VIRTIO_NET_F_CTRL_RX
 VIRTIO_NET_F_CTRL_RX is dependant on VIRTIO_NET_F_CTRL_VQ. Observed that
 virtio-net driver in guest would crash with only CTRL_RX enabled.
Thread-Index: AQHQPIRN+hHAxiQBmkSVnT+JR8KmjZzaWSRg
Date: Sat, 31 Jan 2015 15:24:04 +0000
Message-ID: <C37D651A908B024F974696C65296B57B0F37A14E@SHSMSX101.ccr.corp.intel.com>
References: <1422242440-28948-1-git-send-email-huawei.xie@intel.com>
 <1422242440-28948-2-git-send-email-huawei.xie@intel.com>
 <54CB7208.6040903@huawei.com>
In-Reply-To: <54CB7208.6040903@huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [RFC PATCH v2 01/14] enable VIRTIO_NET_F_CTRL_RX
 VIRTIO_NET_F_CTRL_RX is dependant on VIRTIO_NET_F_CTRL_VQ. Observed that
 virtio-net driver in guest would crash with only CTRL_RX enabled.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Jan 2015 15:24:31 -0000

>=20
> Hi,Xie
>=20
> If don't have features VIRTIO_NET_F_CTRL_VQ and  VIRTIO_NET_F_CTRL_RX
> what would happen?
> Why add the two features?

If virtio-net driver doesn't require those two features, it will work fine.

Changchun cced added these two features for control queue support and broad=
cast/multicast support.

> --
> Regards,
> Haifeng