DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xie, Huawei" <huawei.xie@intel.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Vhost-user early adopter feedback
Date: Wed, 25 Feb 2015 07:46:56 +0000	[thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B0F3A436D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20150218075923.GA23117@irqsave.net>

On 2/18/2015 3:59 PM, Benoît Canet wrote:
> Hello Xie,
>
> As promized I integrated your vhost-user patchset from january in my vswitch.
>
> I just tried it, it works pretty well.
>
> I just had a minor bug with rte_vhost_driver_register taking ownership of the
> string patch pointer too late. I freed it out of habit just after registering in the
> caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I
> allocated later. Maybe an early strdup() would fix this.
Thanks.
Do you mean we duplicate a string from the first parameter path, like
vserver->path = strdup(path) ?
If this was the case, it was ever in my mind. We would do this if
necessary.
>
> The last patch of your new version is really a great idea since it will
> simplify a lot the socket creation and management code.
>
> Best regards
>
> Benoît
>
>


  reply	other threads:[~2015-02-25  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18  7:59 Benoît Canet
2015-02-25  7:46 ` Xie, Huawei [this message]
2015-02-25 11:32   ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C37D651A908B024F974696C65296B57B0F3A436D@SHSMSX101.ccr.corp.intel.com \
    --to=huawei.xie@intel.com \
    --cc=benoit.canet@irqsave.net \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).