From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 365A89A92 for ; Wed, 25 Feb 2015 08:47:36 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 24 Feb 2015 23:47:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,643,1418112000"; d="scan'208";a="656872006" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga001.jf.intel.com with ESMTP; 24 Feb 2015 23:47:34 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 25 Feb 2015 15:46:58 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.161]) with mapi id 14.03.0195.001; Wed, 25 Feb 2015 15:46:57 +0800 From: "Xie, Huawei" To: =?iso-8859-1?Q?Beno=C3=AEt_Canet?= Thread-Topic: Vhost-user early adopter feedback Thread-Index: AdBQzzp0zmhBm0UtTvSB0oOCZI3m7w== Date: Wed, 25 Feb 2015 07:46:56 +0000 Message-ID: References: <20150218075923.GA23117@irqsave.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Vhost-user early adopter feedback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2015 07:47:36 -0000 On 2/18/2015 3:59 PM, Beno=EEt Canet wrote:=0A= > Hello Xie,=0A= >=0A= > As promized I integrated your vhost-user patchset from january in my vswi= tch.=0A= >=0A= > I just tried it, it works pretty well.=0A= >=0A= > I just had a minor bug with rte_vhost_driver_register taking ownership of= the=0A= > string patch pointer too late. I freed it out of habit just after registe= ring in the=0A= > caller and when ifname[IFNAMESIZ] was written the pointer was used for a = new string I=0A= > allocated later. Maybe an early strdup() would fix this.=0A= Thanks.=0A= Do you mean we duplicate a string from the first parameter path, like=0A= vserver->path =3D strdup(path) ?=0A= If this was the case, it was ever in my mind. We would do this if=0A= necessary.=0A= >=0A= > The last patch of your new version is really a great idea since it will= =0A= > simplify a lot the socket creation and management code.=0A= >=0A= > Best regards=0A= >=0A= > Beno=EEt=0A= >=0A= >=0A= =0A=