From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AC0433796 for ; Mon, 23 Mar 2015 08:52:36 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 23 Mar 2015 00:52:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,450,1422950400"; d="scan'208";a="702671797" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga002.jf.intel.com with ESMTP; 23 Mar 2015 00:52:33 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 23 Mar 2015 15:52:32 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.36]) by shsmsx102.ccr.corp.intel.com ([169.254.2.198]) with mapi id 14.03.0224.002; Mon, 23 Mar 2015 15:52:31 +0800 From: "Xie, Huawei" To: "Butler, Siobhan A" , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] vhost library doc update Thread-Index: AQHQXBeeua7YAawNK0+fiOtoRmOXdw== Date: Mon, 23 Mar 2015 07:52:31 +0000 Message-ID: References: <1426090941-18785-1-git-send-email-huawei.xie@intel.com> <0C5AFCA4B3408848ADF2A3073F7D8CC86D559653@IRSMSX109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost library doc update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 07:52:37 -0000 On 3/22/2015 10:00 PM, Butler, Siobhan A wrote: -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie Sent: Wednesday, March 11, 2015 4:22 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] vhost library doc update add vhost user documentation Signed-off-by: Huawei Xie --- doc/guides/prog_guide/vhost_lib.rst | 52 ++++++++++++++++++++++++++++++------- 1 file changed, 42 insertions(+), 10 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index 0b6eda7..ab35b74 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++ b/doc/guides/prog_guide/vhost_lib.rst @@ -31,25 +31,28 @@ Vhost Library =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D -The vhost cuse (cuse: user space character device driver) library implemen= ts a -vhost cuse driver. It also creates, manages and destroys vhost devices f= or - corresponding virtio devices in the guest. Vhost supported vSwitch could register -callbacks to this library, which will be called when a vhost devi= ce is activated -or deactivated by guest virtual machine. +The vhost library implements a user space vhost driver. It supports +both vhost-cuse +(cuse: user space character device) and vhost-user(user space socket server). +It also creates, manages and destroys vhost devices for corresponding +virtio devices in the guest. Vhost supported vSwitch could register +callbacks to this library, which will be called when a vhost device is +activated or deactivated by guest virtual machine. Vhost API Overview ------------------ * Vhost driver registration - rte_vhost_driver_register registers the vhost cuse driver into the system. - Character device file will be created in the /dev directory. + rte_vhost_driver_register registers the vhost driver into the system= . + For vhost-cuse, character device file will be created under the /dev directory. Character device name is specified as the parameter. + For vhost-user, a unix domain socket server will be created with the parameter as + the local socket path. * Vhost session start rte_vhost_driver_session_start starts the vhost session loop. - Vhost cuse session is an infinite blocking loop. + Vhost session is an infinite blocking loop. Put the session in a dedicate DPDK thread. * Callback register @@ -73,6 +76,8 @@ Vhost API Overview Vhost Implementation -------------------- +Vhost cuse implementation +~~~~~~~~~~~~~~~~~~~~~~~~~ When vSwitch registers the vhost driver, it will register a cuse device dr= iver into the system and creates a character device file. This cuse driver will receive vhost open/release/IOCTL message from QEMU simulator. @@ -89,13 +94,40 @@ which means vhost could access the shared virtio ring and the guest physical address specified in the entry of the ring. The guest virtual machine tells the vhost whether the virtio device is rea= dy - for processing or is de-activated through VHOST_SET_BACKEND message. +for processing or is de-activated through VHOST_NET_SET_BACKEND message. The registered callback from vSwitch will be called. When the release call is released, vhost will destroy the device. +Vhost user implementation +~~~~~~~~~~~~~~~~~~~~~~~~~ +When vSwitch registers a vhost driver, it will create a unix domain +socket server into the system. This server will listen for a connection +and process the vhost message from QEMU simulator. + +When there is a new socket connection, it means a new virtio device has +been created in the guest virtual machine, and the vhost driver will creat= e a vhost device for this virtio device. + +For messages with a file descriptor, the file descriptor could be +directly used in the vhost process as it is already installed by unix doma= in socket. + * VHOST_SET_MEM_TABLE + * VHOST_SET_VRING_KICK + * VHOST_SET_VRING_CALL + * VHOST_SET_LOG_FD + * VHOST_SET_VRING_ERR + +For VHOST_SET_MEM_TABLE message, QEMU will send us information for each +memory region and its file descriptor in the ancillary data of the message= . The fd is used to map that region. + +There is no VHOST_NET_SET_BACKEND message as in vhost cuse to signal us +whether virtio device is ready or should be stopped. +VHOST_SET_VRING_KICK is used as the signal to put the vhost device onto data plane. +VHOST_GET_VRING_BASE is used as the signal to remove vhost device from data plane. + +When the socket connection is closed, vhost will destroy the device. + Vhost supported vSwitch reference --------------------------------- -For how to support vhost in vSwitch, please refer to vhost example in the +For more vhost details and how to support vhost in vSwitch, please +refer to vhost example in the DPDK Sample Applications Guide. -- 1.8.1.4 Hi Huawei, Having some issues with trailing white space in this patch can you please c= heck it? Thanks Siobhan Hi Siobhan: I check the patch, and don't know if this is your question. This is a bit weird. Hope i can explain it clearly. For example, in line 17, you can see a white space there in the patch file. git tool add a white space, but actually there is no change to that line, i.e, no deletion, no addition, no modification. git check patch will not report error, and git apply will also works fine. Vhost Library =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D line 17: whitespace