From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 05C085A37
 for <dev@dpdk.org>; Mon, 18 May 2015 08:07:17 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 17 May 2015 23:07:11 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,451,1427785200"; d="scan'208";a="572921288"
Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91])
 by orsmga003.jf.intel.com with ESMTP; 17 May 2015 23:07:10 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Mon, 18 May 2015 14:06:02 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.120]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.94]) with mapi id 14.03.0224.002;
 Mon, 18 May 2015 14:06:01 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Pavel Boldin <pboldin@mirantis.com>
Thread-Topic: [dpdk-dev] [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to
 a function
Thread-Index: AQHQkTC2GLUJcdnGW02YhgI21tly8Q==
Date: Mon, 18 May 2015 06:06:00 +0000
Message-ID: <C37D651A908B024F974696C65296B57B0F4A20DD@SHSMSX101.ccr.corp.intel.com>
References: <1427123731-15654-1-git-send-email-pboldin@mirantis.com>
 <1427994080-10163-1-git-send-email-pboldin@mirantis.com>
 <1427994080-10163-2-git-send-email-pboldin@mirantis.com>
 <C37D651A908B024F974696C65296B57B0F476887@SHSMSX101.ccr.corp.intel.com>
 <CACf4_B8MDfkaEk5jMjMbEw9F8LsBVLA9TUWwOBU=SCAxzFmSFw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to
 a function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 06:07:18 -0000

On 5/7/2015 9:17 PM, Pavel Boldin wrote:


On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei <huawei.xie@intel.com<mailto:h=
uawei.xie@intel.com>> wrote:
On 4/3/2015 1:02 AM, Pavel Boldin wrote:
> Move ioctl `EVENTFD_COPY' handler code to an inline function.
Pavel:
There is no necessity to inline this function.
Xie, there is even no necessity to split this in a five piece patchseries. =
I did that solely for the purpose of clean reading.

There is no necessity to inline any single-used functions as long the compi=
ler is decent. But I prefer to instruct compiler to do this explictly so th=
ere is no call/ret path in the generated code.

The purpose of inline or not is not for friendly reading. inline is for per=
formance only.
Pavel


/huawei