From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <huawei.xie@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E1260E62 for <dev@dpdk.org>; Mon, 8 Jun 2015 17:46:54 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 08 Jun 2015 08:38:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,574,1427785200"; d="scan'208";a="504859148" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by FMSMGA003.fm.intel.com with ESMTP; 08 Jun 2015 08:38:51 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 8 Jun 2015 23:38:50 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.120]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0224.002; Mon, 8 Jun 2015 23:38:49 +0800 From: "Xie, Huawei" <huawei.xie@intel.com> To: "Loftus, Ciara" <ciara.loftus@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket Thread-Index: AdCiATaMNV5/Cz4ITceY7KPbs///KQ== Date: Mon, 8 Jun 2015 15:38:49 +0000 Message-ID: <C37D651A908B024F974696C65296B57B0F4F2676@SHSMSX101.ccr.corp.intel.com> References: <1433209800-29091-1-git-send-email-huawei.xie@intel.com> <1433474786-704-1-git-send-email-huawei.xie@intel.com> <74F120C019F4A64C9B78E802F6AD4CC220567AC8@IRSMSX106.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 08 Jun 2015 15:46:55 -0000 On 6/5/2015 5:04 PM, Loftus, Ciara wrote:=0A= >=0A= >> -----Original Message-----=0A= >> From: Xie, Huawei=0A= >> Sent: Friday, June 05, 2015 4:26 AM=0A= >> To: dev@dpdk.org=0A= >> Cc: Loftus, Ciara; Xie, Huawei; Sun, Peng A=0A= >> Subject: [PATCH v2] vhost: provide vhost API to unregister vhost unix do= main=0A= >> socket=0A= >>=0A= >> rte_vhost_driver_unregister will remove the listenfd from event list, an= d=0A= >> then close it.=0A= >>=0A= >> Signed-off-by: Huawei Xie <huawei.xie@intel.com>=0A= >> Signed-off-by: Peng Sun <peng.a.sun@intel.com>=0A= >> ---=0A= >> lib/librte_vhost/rte_virtio_net.h | 3 ++=0A= >> lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 9 ++++=0A= >> lib/librte_vhost/vhost_user/vhost-net-user.c | 68=0A= >> +++++++++++++++++++++++-----=0A= >> lib/librte_vhost/vhost_user/vhost-net-user.h | 2 +-=0A= >> 4 files changed, 69 insertions(+), 13 deletions(-)=0A= >>=0A= >>=0A= > Acked-by: Ciara Loftus <ciara.loftus@intel.com>=0A= >=0A= >=0A= >=0A= Thomas:=0A= Comments to this patch?=0A= This patch will remove the socket file and associated listen fd.=0A= In future, I would also look at whether there is opportunity to attach a=0A= id to each vhost user net interface from QEMU.=0A= Currently DPDK OVS creates a socket file for each virtio device and use=0A= the file path as the id for the port.=0A= =0A= /huawei=0A= =0A= =0A=