From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 3D404C4F4
 for <dev@dpdk.org>; Thu, 18 Jun 2015 03:42:38 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 17 Jun 2015 18:42:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,636,1427785200"; d="scan'208";a="589945710"
Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96])
 by orsmga003.jf.intel.com with ESMTP; 17 Jun 2015 18:42:36 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Thu, 18 Jun 2015 09:40:44 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.246]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.46]) with mapi id 14.03.0224.002;
 Thu, 18 Jun 2015 09:40:36 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister
 vhost unix domain socket
Thread-Index: AdCpZ8WhNV5/Cz4ITceY7KPbs///KQ==
Date: Thu, 18 Jun 2015 01:40:36 +0000
Message-ID: <C37D651A908B024F974696C65296B57B0F51D92B@SHSMSX101.ccr.corp.intel.com>
References: <1433209800-29091-1-git-send-email-huawei.xie@intel.com>
 <1433474786-704-1-git-send-email-huawei.xie@intel.com>
 <1639719.yBz0fy8sC7@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister
 vhost unix domain socket
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 01:42:38 -0000

On 6/18/2015 5:02 AM, Thomas Monjalon wrote:=0A=
> 2015-06-05 11:26, Huawei Xie:=0A=
>> rte_vhost_driver_unregister will remove the listenfd from event list, an=
d then close it.=0A=
>>=0A=
>> Signed-off-by: Huawei Xie <huawei.xie@intel.com>=0A=
>> Signed-off-by: Peng Sun <peng.a.sun@intel.com>=0A=
>> ---=0A=
>>  lib/librte_vhost/rte_virtio_net.h            |  3 ++=0A=
>>  lib/librte_vhost/vhost_cuse/vhost-net-cdev.c |  9 ++++=0A=
>>  lib/librte_vhost/vhost_user/vhost-net-user.c | 68 +++++++++++++++++++++=
++-----=0A=
>>  lib/librte_vhost/vhost_user/vhost-net-user.h |  2 +-=0A=
> A function is added to the API without update of the .map file?=0A=
Get the comment from Panu. Would submit v3 patch.=0A=
=0A=
>=0A=
> Could it be used in a test or an example? It would prevent to break=0A=
> it or forget to add it in the .map.=0A=
>=0A=
Now in vhost example, we only register one socket and never unregister it.=
=0A=
Would evaluate calling this API in vhost example in future.=0A=
>=0A=
>=0A=
=0A=