From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id A9FE2C384
 for <dev@dpdk.org>; Fri, 10 Jul 2015 16:27:39 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 10 Jul 2015 07:27:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,446,1432623600"; d="scan'208";a="744498555"
Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98])
 by fmsmga001.fm.intel.com with ESMTP; 10 Jul 2015 07:27:37 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Fri, 10 Jul 2015 22:27:35 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.246]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.129]) with mapi id 14.03.0224.002;
 Fri, 10 Jul 2015 22:27:35 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, Pavel Boldin
 <pboldin@mirantis.com>
Thread-Topic: [dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace
 copy-pasted sys_close
Thread-Index: AdC7HI/VV8dlCf+ynE6WaHWpLcGybQ==
Date: Fri, 10 Jul 2015 14:27:34 +0000
Message-ID: <C37D651A908B024F974696C65296B57B0F56C326@SHSMSX101.ccr.corp.intel.com>
References: <1427994080-10163-1-git-send-email-pboldin@mirantis.com>
 <1429184910-30186-5-git-send-email-pboldin@mirantis.com>
 <C37D651A908B024F974696C65296B57B0F476567@SHSMSX101.ccr.corp.intel.com>
 <1665929.SfCu3BinAE@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace
 copy-pasted sys_close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2015 14:27:40 -0000

On 6/17/2015 11:24 PM, Thomas Monjalon wrote:=0A=
> 2015-05-07 06:54, Xie, Huawei:=0A=
>> On 4/16/2015 7:48 PM, Pavel Boldin wrote:=0A=
>>> +	/* Closing the source_fd */=0A=
>>> +	ret =3D sys_close(eventfd_copy.source_fd);=0A=
>> Pavel:=0A=
>> Here we close the fd and re-install a new file on this fd later. =0A=
>> sys_close does all cleanup.=0A=
>> But, for instance, if we allocate new fd later, normally it will reuse=
=0A=
>> the just freed fds by sys_close, is there issue here? =0A=
> Pavel, Huawei,=0A=
> Could we come to a conclusion on this patch series please?=0A=
For the previous 3 patches, i am OK except that i don't think inline is=0A=
needed explicitly for non-performance critical function.=0A=
For this patch, didn't check the fs code.=0A=
=0A=
>=0A=
>=0A=
=0A=