From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7669C5A36 for ; Fri, 18 Sep 2015 08:29:27 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 17 Sep 2015 23:29:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,550,1437462000"; d="scan'208";a="792288776" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by fmsmga001.fm.intel.com with ESMTP; 17 Sep 2015 23:29:25 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 18 Sep 2015 14:29:00 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.75]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.110]) with mapi id 14.03.0248.002; Fri, 18 Sep 2015 14:28:52 +0800 From: "Xie, Huawei" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] vhost-net stops sending to virito pmd -- already fixed? Thread-Index: AdDx20k/VVsIEQ6iVkioYbNKSNqzXQ== Date: Fri, 18 Sep 2015 06:28:52 +0000 Message-ID: References: <2603066.XvJpW2pAu2@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] vhost-net stops sending to virito pmd -- already fixed? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2015 06:29:28 -0000 On 9/14/2015 5:44 AM, Thomas Monjalon wrote:=0A= > Hi,=0A= >=0A= > 2015-09-11 12:32, Kyle Larose:=0A= >> Looking through the version tree for virtio_rxtx.c, I saw the following= =0A= >> commit:=0A= >>=0A= >> http://dpdk.org/browse/dpdk/commit/lib/librte_pmd_virtio?id=3D8c09c20fb4= cde76e53d87bd50acf2b441ecf6eb8=0A= >>=0A= >> Does anybody know offhand if the issue fixed by that commit could be the= =0A= >> root cause of what I am seeing?=0A= > I won't have the definitive answer but I would like to use your question= =0A= > to highlight a common issue in git messages:=0A= >=0A= > PLEASE, authors of fixes, explain the bug you are fixing and how it can= =0A= > be reproduced. Good commit messages are REALLY read and useful.=0A= Thomas:=0A= Thanks for reminder. I am not the author of this specific patch, :). We=0A= will try to keep commit message simple, enough and useful.=0A= In my opinion, this commit message is totally ok. It doesn't fix=0A= anything but remove some unnecessary ring update operations.=0A= =0A= >=0A= > Thanks=0A= >=0A= >=0A= =0A=