From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <huawei.xie@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EA17891B7 for <dev@dpdk.org>; Tue, 20 Oct 2015 11:06:58 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 20 Oct 2015 02:06:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,706,1437462000"; d="scan'208";a="815064226" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 20 Oct 2015 02:06:57 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Oct 2015 02:06:57 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Oct 2015 02:06:57 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0248.002; Tue, 20 Oct 2015 17:06:55 +0800 From: "Xie, Huawei" <huawei.xie@intel.com> To: Pavel Boldin <pboldin@mirantis.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v5 1/4] vhost: eventfd_link: refactoring EVENTFD_COPY handler Thread-Index: AdELFqpVBWrahJnWTZaqVVez9Cd5NQ== Date: Tue, 20 Oct 2015 09:06:54 +0000 Message-ID: <C37D651A908B024F974696C65296B57B4B12F3B7@SHSMSX101.ccr.corp.intel.com> References: <1429184910-30186-2-git-send-email-pboldin@mirantis.com> <1440787880-7079-1-git-send-email-pboldin@mirantis.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/4] vhost: eventfd_link: refactoring EVENTFD_COPY handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 20 Oct 2015 09:06:59 -0000 On 8/29/2015 2:51 AM, Pavel Boldin wrote:=0A= > * Move ioctl `EVENTFD_COPY' code to a separate function=0A= > * Remove extra #includes=0A= > * Introduce function fget_from_files=0A= > * Fix ioctl return values=0A= >=0A= > Signed-off-by: Pavel Boldin <pboldin@mirantis.com>=0A= Basically OK with this patch since we have reviewed before.=0A= Could you split the patch, one change each patch? Thomas will require=0A= you to do this too. :). I see you have also changed when to call=0A= put_files_struct. It is better put it in a separate patch with the reason.= =0A= Another thing is code style. Run checkpatch.pl against your patch. There=0A= are some issues.=0A=