From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 15B3BC3C8
 for <dev@dpdk.org>; Fri, 23 Oct 2015 03:38:16 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 22 Oct 2015 18:38:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,185,1444719600"; d="scan'208";a="800723042"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga001.jf.intel.com with ESMTP; 22 Oct 2015 18:38:15 -0700
Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 22 Oct 2015 18:38:13 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 22 Oct 2015 18:38:13 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.253]) with mapi id 14.03.0248.002;
 Fri, 23 Oct 2015 09:38:11 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [PATCH v4 7/7] virtio: pick simple rx/tx func
Thread-Index: AdENM3ndnN6qb0WbRC+1fmoc0rj1TA==
Date: Fri, 23 Oct 2015 01:38:11 +0000
Message-ID: <C37D651A908B024F974696C65296B57B4B139534@SHSMSX101.ccr.corp.intel.com>
References: <1443537953-23917-1-git-send-email-huawei.xie@intel.com>
 <1445515791-25909-1-git-send-email-huawei.xie@intel.com>
 <1445515791-25909-8-git-send-email-huawei.xie@intel.com>
 <20151022095856.5cbcf8c3@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 7/7] virtio: pick simple rx/tx func
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 01:38:17 -0000

On 10/23/2015 12:59 AM, Stephen Hemminger wrote:=0A=
> On Thu, 22 Oct 2015 20:09:51 +0800=0A=
> Huawei Xie <huawei.xie@intel.com> wrote:=0A=
>=0A=
>> +	/* Use simple rx/tx func if single segment and no offloads */=0A=
>> +	if ((tx_conf->txq_flags & VIRTIO_SIMPLE_FLAGS) =3D=3D VIRTIO_SIMPLE_FL=
AGS &&=0A=
>> +	     !vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF))=0A=
> Since with QEMU/KVM the code will negotiate to use MRG_RXBUF, this=0A=
> code path will not get used in common case anyway.=0A=
>=0A=
Yes, the common configuration is merge-able enabled.=0A=
We need to add mrg_rxbuf=3Doff(in qemu command line), or disable=0A=
merge-able feature(in switch application) through vhost API for=0A=
non-mergable.=0A=
=0A=
=0A=