From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AFC9B5686 for ; Mon, 26 Oct 2015 02:45:40 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 25 Oct 2015 18:45:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,199,1444719600"; d="scan'208";a="835288393" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 25 Oct 2015 18:45:39 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Oct 2015 18:45:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Oct 2015 18:45:39 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.47]) with mapi id 14.03.0248.002; Mon, 26 Oct 2015 09:45:38 +0800 From: "Xie, Huawei" To: Pavel Boldin Thread-Topic: [PATCH v5 3/4] vhost: using EVENTFD_COPY2 Thread-Index: AdELHRRH4BJ5xeaFSaePY3NFxFWejA== Date: Mon, 26 Oct 2015 01:45:37 +0000 Message-ID: References: <1429184910-30186-2-git-send-email-pboldin@mirantis.com> <1440787880-7079-3-git-send-email-pboldin@mirantis.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_COPY2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2015 01:45:41 -0000 On 10/21/2015 8:16 PM, Pavel Boldin wrote:=0A= > Xie,=0A= >=0A= > Please find my comments intermixed below.=0A= >=0A= > On Tue, Oct 20, 2015 at 12:52 PM, Xie, Huawei > wrote:=0A= >=0A= > Thanks Pavel for this work.=0A= > This is what we think is the better implementation for eventfd=0A= > proxy, in=0A= > our last review.=0A= > Could you add an additional patch to remove the old implementation?= =0A= >=0A= > I'm not really sure if we should do it -- imagine upgrading from one=0A= > version of DPDK to another.=0A= > Given the current implementation there is a backward compatibility.=0A= I couldn't image the case any one would run old dpdk app with the new=0A= dpdk module. However I am ok you leave it here, :), we could remove this=0A= in next release.=0A= Could you finish rebasing the patch before end of next week, otherwise=0A= it will lose chance of being merged.=0A= > =0A= >=0A= >=0A= > Again, please run checkpatch.pl against=0A= > your patch.=0A= >=0A= > Oops. Thanks for pointing out.=0A= > =0A= >=0A= > On 8/29/2015 2:51 AM, Pavel Boldin wrote:=0A= >=0A= > [...]=0A= > > +=0A= > > +int=0A= > > +eventfd_init(void)=0A= > > +{=0A= > > + if (eventfd_link > 0)=0A= > 0 could be valid fd. Change it to:=0A= >=0A= > Got it. Thanks.=0A= > =0A= >=0A= > if (eventfd_link >=3D 0)=0A= > Change elsewhere if i miss it.=0A= > > +int=0A= > > +eventfd_free(void)=0A= > > +{=0A= > > + if (eventfd_link > 0)=0A= > same as above:=0A= > if (eventfd_link >=3D 0)=0A= >=0A= > [...]=0A= >=0A= >=0A= > --=0A= > Sincerely,=0A= > Pavel=0A= =0A=