* [dpdk-dev] [PATCH v2] vhost: Fix wrong handling of virtqueue array index
@ 2015-10-28 2:59 Tetsuya Mukawa
2015-10-28 3:35 ` Xie, Huawei
0 siblings, 1 reply; 3+ messages in thread
From: Tetsuya Mukawa @ 2015-10-28 2:59 UTC (permalink / raw)
To: dev; +Cc: ann.zhuangyanying
The patch fixes wrong handling of virtqueue array index when
GET_VRING_BASE message comes.
---
lib/librte_vhost/vhost_user/virtio-net-user.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c b/lib/librte_vhost/vhost_user/virtio-net-user.c
index a998ad8..d07452a 100644
--- a/lib/librte_vhost/vhost_user/virtio-net-user.c
+++ b/lib/librte_vhost/vhost_user/virtio-net-user.c
@@ -300,13 +300,9 @@ user_get_vring_base(struct vhost_device_ctx ctx,
* sent and only sent in vhost_vring_stop.
* TODO: cleanup the vring, it isn't usable since here.
*/
- if (dev->virtqueue[state->index + VIRTIO_RXQ]->kickfd >= 0) {
- close(dev->virtqueue[state->index + VIRTIO_RXQ]->kickfd);
- dev->virtqueue[state->index + VIRTIO_RXQ]->kickfd = -1;
- }
- if (dev->virtqueue[state->index + VIRTIO_TXQ]->kickfd >= 0) {
- close(dev->virtqueue[state->index + VIRTIO_TXQ]->kickfd);
- dev->virtqueue[state->index + VIRTIO_TXQ]->kickfd = -1;
+ if (dev->virtqueue[state->index]->kickfd >= 0) {
+ close(dev->virtqueue[state->index]->kickfd);
+ dev->virtqueue[state->index]->kickfd = -1;
}
return 0;
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] vhost: Fix wrong handling of virtqueue array index
2015-10-28 2:59 [dpdk-dev] [PATCH v2] vhost: Fix wrong handling of virtqueue array index Tetsuya Mukawa
@ 2015-10-28 3:35 ` Xie, Huawei
2015-10-28 3:45 ` Tetsuya Mukawa
0 siblings, 1 reply; 3+ messages in thread
From: Xie, Huawei @ 2015-10-28 3:35 UTC (permalink / raw)
To: Tetsuya Mukawa, dev; +Cc: ann.zhuangyanying
Missed signoff?
On 10/28/2015 11:00 AM, Tetsuya Mukawa wrote:
> The patch fixes wrong handling of virtqueue array index when
> GET_VRING_BASE message comes.
> ---
> lib/librte_vhost/vhost_user/virtio-net-user.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] vhost: Fix wrong handling of virtqueue array index
2015-10-28 3:35 ` Xie, Huawei
@ 2015-10-28 3:45 ` Tetsuya Mukawa
0 siblings, 0 replies; 3+ messages in thread
From: Tetsuya Mukawa @ 2015-10-28 3:45 UTC (permalink / raw)
To: Xie, Huawei, dev; +Cc: ann.zhuangyanying
On 2015/10/28 12:35, Xie, Huawei wrote:
> Missed signoff?
> On 10/28/2015 11:00 AM, Tetsuya Mukawa wrote:
>> The patch fixes wrong handling of virtqueue array index when
>> GET_VRING_BASE message comes.
>> ---
>> lib/librte_vhost/vhost_user/virtio-net-user.c | 10 +++-------
>> 1 file changed, 3 insertions(+), 7 deletions(-)
>>
>>
Oops, I forgot it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-28 3:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-28 2:59 [dpdk-dev] [PATCH v2] vhost: Fix wrong handling of virtqueue array index Tetsuya Mukawa
2015-10-28 3:35 ` Xie, Huawei
2015-10-28 3:45 ` Tetsuya Mukawa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).