From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D85165A32 for ; Mon, 2 Nov 2015 09:50:06 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 02 Nov 2015 00:50:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,233,1444719600"; d="scan'208";a="840944534" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 02 Nov 2015 00:49:15 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 2 Nov 2015 00:49:15 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 2 Nov 2015 00:49:14 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.106]) with mapi id 14.03.0248.002; Mon, 2 Nov 2015 16:49:13 +0800 From: "Xie, Huawei" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 5/8] virtio: virtio vec rx Thread-Index: AdEVFMgj4FG6RsTIQZua6Xgs5ian1A== Date: Mon, 2 Nov 2015 08:49:12 +0000 Message-ID: References: <1443537953-23917-1-git-send-email-huawei.xie@intel.com> <27298667.Vrp1X8IJFV@xps13> <2074733.DLSOutviVq@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 5/8] virtio: virtio vec rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 08:50:07 -0000 On 11/2/2015 3:31 PM, Thomas Monjalon wrote:=0A= > 2015-11-02 02:18, Xie, Huawei:=0A= >> On 10/31/2015 2:21 AM, Thomas Monjalon wrote:=0A= >>> Sorry, there is a clang error.=0A= >>>=0A= >>> 2015-10-29 22:53, Huawei Xie:=0A= >>>> + _mm_prefetch((const void *)rused, _MM_HINT_T0);=0A= >>> virtio_rxtx_simple.c:197:2: error: cast from 'const void *' to=0A= >>> 'void *' drops const qualifier=0A= >> This is weird. This conversion is actually from 'void *' to 'const void= =0A= >> *', not the opposite, so there should be no error.=0A= >> I checked clang build, it doesn't report error.=0A= >> clang version 3.3 (tags/RELEASE_33/rc2)=0A= > I'm using clang 3.6.2.=0A= > Anybody else to check please?=0A= Thomas:=0A= =0A= I checked clang-3.5 on Fedora 22 and clang-3.6 on Ubuntu 15.04.=0A= Clang-3.6 reports warnings, but the definition of this macro doesn't change= .=0A= =0A= Why (const void*) conversion is used in the code is because when=0A= __OPTIMIZE__ is defined, GCC defines first parameter to be "const void *".= =0A= =0A= Could you add the following macro(used in other vec pmds as well) before=0A= virtqueue_enqueue_recv_refill_simple or do i need to submit a new patchset?= =0A= =0A= +#ifndef __INTEL_COMPILER=0A= +#pragma GCC diagnostic ignored "-Wcast-qual"=0A= +#endif=0A= =0A= =0A=