From: "Xie, Huawei" <huawei.xie@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] Fixes following error on gcc 4.4.7:
Date: Wed, 9 Dec 2015 13:28:40 +0000 [thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B4BB83A5F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1449663630-83289-1-git-send-email-pablo.de.lara.guarch@intel.com>
On 12/9/2015 8:20 PM, De Lara Guarch, Pablo wrote:
> make: Entering directory `/tmp/dpdk-tmp/examples/vhost'
> CC main.o
[...]
> - rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf);
> + rte_ring_sc_dequeue(vpool->ring, (void *)mbuf);
Here we are expecting the address of &mbuf, not mbuf, which is NULL.
> if (unlikely(mbuf == NULL)) {
> LOG_DEBUG(VHOST_DATA,
> "(%"PRIu64") in attach_rxmbuf_zcp: "
> @@ -1801,7 +1801,7 @@ virtio_tx_route_zcp(struct virtio_net *dev, struct rte_mbuf *m,
>
> /* Allocate an mbuf and populate the structure. */
> vpool = &vpool_array[MAX_QUEUES + vmdq_rx_q];
> - rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf);
> + rte_ring_sc_dequeue(vpool->ring, (void *)mbuf);
Same as above.
> if (unlikely(mbuf == NULL)) {
> struct vhost_virtqueue *vq = dev->virtqueue[VIRTIO_TXQ];
> RTE_LOG(ERR, VHOST_DATA,
next prev parent reply other threads:[~2015-12-09 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 11:23 [dpdk-dev] [PATCH] examples/vhost: fix strict aliasing error on gcc 4.4.7 Pablo de Lara
2015-12-09 9:12 ` Xie, Huawei
2015-12-09 9:39 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2015-12-09 10:32 ` Bruce Richardson
2015-12-09 10:45 ` Xie, Huawei
2015-12-09 10:52 ` De Lara Guarch, Pablo
2015-12-09 11:09 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2015-12-09 12:20 ` [dpdk-dev] [PATCH v4] Fixes following error on gcc 4.4.7: Pablo de Lara
2015-12-09 13:28 ` Xie, Huawei [this message]
2015-12-09 14:01 ` De Lara Guarch, Pablo
2015-12-09 14:12 ` Xie, Huawei
2015-12-09 14:26 ` [dpdk-dev] [PATCH v5] examples/vhost: fix strict aliasing error on gcc 4.4.7 Pablo de Lara
2015-12-09 14:33 ` Xie, Huawei
2015-12-09 20:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C37D651A908B024F974696C65296B57B4BB83A5F@SHSMSX103.ccr.corp.intel.com \
--to=huawei.xie@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).