From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4BB839231 for ; Tue, 5 Jan 2016 08:17:04 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 04 Jan 2016 23:17:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,524,1444719600"; d="scan'208";a="23755493" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 04 Jan 2016 23:17:04 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Jan 2016 23:17:02 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Jan 2016 23:17:02 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.111]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0248.002; Tue, 5 Jan 2016 15:16:54 +0800 From: "Xie, Huawei" To: "dev@dpdk.org" Thread-Topic: [PATCH] vhost: remove lockless enqueue to the virtio ring Thread-Index: AdFHiQ3UcjIqRVm8TQuePU+NP698xw== Date: Tue, 5 Jan 2016 07:16:54 +0000 Message-ID: References: <1451918787-85887-1-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "ann.zhuangyanying@huawei.com" Subject: Re: [dpdk-dev] [PATCH] vhost: remove lockless enqueue to the virtio ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 07:17:04 -0000 On 1/5/2016 2:42 PM, Xie, Huawei wrote:=0A= > This patch removes the internal lockless enqueue implmentation.=0A= > DPDK doesn't support receiving/transmitting packets from/to the same=0A= > queue. Vhost PMD wraps vhost device as normal DPDK port. DPDK=0A= > applications normally have their own lock implmentation when enqueue=0A= > packets to the same queue of a port.=0A= >=0A= > The atomic cmpset is a costly operation. This patch should help=0A= > performance a bit.=0A= >=0A= > Signed-off-by: Huawei Xie =0A= This patch modifies the API's behavior, which is also a trivial ABI=0A= change. In my opinion, application shouldn't rely on previous behavior.=0A= Anyway, i am checking how to declare the ABI change.=0A=