From: "Xie, Huawei" <huawei.xie@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fix checkpatch errors
Date: Tue, 5 Jan 2016 16:20:12 +0000 [thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B4C5759DE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20241D828@IRSMSX103.ger.corp.intel.com>
On 1/5/2016 6:22 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: Tan, Jianfeng
>> Sent: Tuesday, January 5, 2016 2:21 AM
>> To: Xie, Huawei; dev@dpdk.org
>> Cc: Mcnamara, John; Stephen Hemminger; Yuanhan Liu
>> Subject: RE: [PATCH] fix checkpatch errors
>>
>>
>>
>>> -----Original Message-----
>>> From: Xie, Huawei
>>> Sent: Monday, January 4, 2016 9:52 AM
>>> To: dev@dpdk.org
>>> Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
>>> Subject: [PATCH] fix checkpatch errors
>>>
>>> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
>> ...
>>> mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name));
>>> - return (rte_mempool_lookup((const char *)pool_name));
>>> + return rte_mempool_lookup((const char *)pool_name);
>> Hi Huawei,
>>
>> Assume this patch is to solve below error (reported by checkpatch):
>> ERROR: return is not a function, parentheses are not required
>>
>> So maybe above fix is not necessary? Involve more people to discuss.
>>
>> And please include the error message in the commit message.
> Hi Huawei,
>
> The fix looks good and there was a similar patch applied previously for lib (from Ferruh):
>
> 6307b909b8e0 ("lib: remove extra parenthesis after return")
Oh yes, but no idea why Ferruh Yigit missed so many. I have greped the
pattern, so this patch should fix almost all of them.
>
> However, the commit message could be better. Maybe something like the above:
> "remove extra parentheses".
OK. Weird that my commit message gets lost again. Will send a new one.
>
> John
next prev parent reply other threads:[~2016-01-05 16:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 1:51 Huawei Xie
2016-01-05 2:21 ` Tan, Jianfeng
2016-01-05 2:27 ` Yuanhan Liu
2016-01-05 2:43 ` Xie, Huawei
2016-01-05 10:21 ` Mcnamara, John
2016-01-05 16:20 ` Xie, Huawei [this message]
2016-01-26 17:26 ` [dpdk-dev] [PATCH v2] " Huawei Xie
2016-01-27 18:16 ` Thomas Monjalon
2016-01-28 3:09 ` Xie, Huawei
2016-01-28 8:04 ` Thomas Monjalon
2016-01-28 8:38 ` Xie, Huawei
2016-01-28 9:43 ` Panu Matilainen
2016-01-27 13:58 ` [dpdk-dev] [PATCH v3] remove extra parentheses in return statement Huawei Xie
2016-02-10 14:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C37D651A908B024F974696C65296B57B4C5759DE@SHSMSX101.ccr.corp.intel.com \
--to=huawei.xie@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).