From: "Xie, Huawei" <huawei.xie@intel.com>
To: Pavel Fedin <p.fedin@samsung.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation
Date: Mon, 18 Jan 2016 17:29:48 +0000 [thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B4C5A104F@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <000001d14f6c$2ffe43f0$8ffacbd0$@samsung.com>
On 1/15/2016 4:10 PM, Pavel Fedin wrote:
> Hello!
>
>> If this is the case, i am wondering whether we should include
>> "malfunctioning clients" in commit message. It triggers me to think if
>> there are existing buggy implementations.
> Well... Can you suggest how to rephrase it? May be "if a client is malfunctioning it can..."? I lack fantasy, really, and to tell
> the truth i don't care that much about the exact phrasing, i'm OK with everything.
Thanks.
Because there are not any existing malfunctioning clients which doesn't
send SET_MEM_TABLE message and we think the check is OK anyway,
personally I prefer simple phrases like: check memory table in
SET_VRING_ADDR message.
>
>> Anyway, check is OK.
> Kind regards,
> Pavel Fedin
> Senior Engineer
> Samsung Electronics Research center Russia
>
>
>
next prev parent reply other threads:[~2016-01-18 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 7:32 Pavel Fedin
2016-01-13 9:24 ` Xie, Huawei
2016-01-13 9:40 ` Pavel Fedin
2016-01-13 12:48 ` Xie, Huawei
2016-01-15 8:10 ` Pavel Fedin
2016-01-18 17:29 ` Xie, Huawei [this message]
2016-02-21 9:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C37D651A908B024F974696C65296B57B4C5A104F@SHSMSX101.ccr.corp.intel.com \
--to=huawei.xie@intel.com \
--cc=dev@dpdk.org \
--cc=p.fedin@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).