From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9D7FB8D3A for ; Mon, 18 Jan 2016 18:29:52 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 18 Jan 2016 09:29:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,313,1449561600"; d="scan'208";a="863179942" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 18 Jan 2016 09:29:51 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 18 Jan 2016 09:29:51 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 18 Jan 2016 09:29:50 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Tue, 19 Jan 2016 01:29:48 +0800 From: "Xie, Huawei" To: Pavel Fedin , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation Thread-Index: AdFN5C2FcQQ+0NIpQtu+e7/JrHFEcQ== Date: Mon, 18 Jan 2016 17:29:48 +0000 Message-ID: References: <005a01d14dd4$a02c5340$e084f9c0$@samsung.com> <006a01d14de6$69c68610$3d539230$@samsung.com> <000001d14f6c$2ffe43f0$8ffacbd0$@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.4.80] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2016 17:29:53 -0000 On 1/15/2016 4:10 PM, Pavel Fedin wrote:=0A= > Hello!=0A= >=0A= >> If this is the case, i am wondering whether we should include=0A= >> "malfunctioning clients" in commit message. It triggers me to think if= =0A= >> there are existing buggy implementations.=0A= > Well... Can you suggest how to rephrase it? May be "if a client is malfu= nctioning it can..."? I lack fantasy, really, and to tell=0A= > the truth i don't care that much about the exact phrasing, i'm OK with ev= erything.=0A= =0A= Thanks.=0A= Because there are not any existing malfunctioning clients which doesn't=0A= send SET_MEM_TABLE message and we think the check is OK anyway,=0A= personally I prefer simple phrases like: check memory table in=0A= SET_VRING_ADDR message.=0A= =0A= >=0A= >> Anyway, check is OK.=0A= > Kind regards,=0A= > Pavel Fedin=0A= > Senior Engineer=0A= > Samsung Electronics Research center Russia=0A= >=0A= >=0A= >=0A= =0A=