From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 7E20F93F2
for <dev@dpdk.org>; Wed, 27 Jan 2016 06:57:34 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga104.fm.intel.com with ESMTP; 26 Jan 2016 21:57:33 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,353,1449561600"; d="scan'208";a="869549497"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by orsmga001.jf.intel.com with ESMTP; 26 Jan 2016 21:57:33 -0800
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Tue, 26 Jan 2016 21:57:32 -0800
Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by
FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Tue, 26 Jan 2016 21:57:32 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by
SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0248.002;
Wed, 27 Jan 2016 13:56:57 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Thread-Topic: [PATCH 4/5] vhost: do not use rte_memcpy for virtio_hdr copy
Thread-Index: AdFYrPIunwVMxkBCQWGWJqaoNIdiPQ==
Date: Wed, 27 Jan 2016 05:56:56 +0000
Message-ID: <C37D651A908B024F974696C65296B57B4C5B04AB@SHSMSX101.ccr.corp.intel.com>
References: <1449122773-25510-1-git-send-email-yuanhan.liu@linux.intel.com>
<1449122773-25510-5-git-send-email-yuanhan.liu@linux.intel.com>
<C37D651A908B024F974696C65296B57B4C5AFED9@SHSMSX101.ccr.corp.intel.com>
<20160127032245.GB4257@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.4.160]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>, Victor Kaplansky <vkaplans@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 4/5] vhost: do not use rte_memcpy for
virtio_hdr copy
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jan 2016 05:57:34 -0000
On 1/27/2016 11:22 AM, Yuanhan Liu wrote:=0A=
> On Wed, Jan 27, 2016 at 02:46:39AM +0000, Xie, Huawei wrote:=0A=
>> On 12/3/2015 2:03 PM, Yuanhan Liu wrote:=0A=
>>> + if (vq->vhost_hlen =3D=3D sizeof(struct virtio_net_hdr_mrg_rxbuf)) {=
=0A=
>>> + *(struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)desc_addr =3D hdr;=0A=
>>> + } else {=0A=
>>> + *(struct virtio_net_hdr *)(uintptr_t)desc_addr =3D hdr.hdr;=0A=
>>> + }=0A=
>> Thanks!=0A=
>> We might simplify this further. Just reset the first two fields flags=0A=
>> and gso_type.=0A=
> What's this "simplification" for? Don't even to say that we will add=0A=
> TSO support, which modifies few more files, such as csum_start: reseting=
=0A=
> the first two fields only is wrong here.=0A=
=0A=
I know TSO before commenting, but at least in this implementation and=0A=
this specific patch, i guess zeroing two fields are enough.=0A=
=0A=
What is wrong resetting only two fields?=0A=
=0A=
>=0A=
> --yliu=0A=
>=0A=
=0A=