From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C5D6295DE for ; Thu, 28 Jan 2016 04:09:33 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 27 Jan 2016 19:09:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,356,1449561600"; d="scan'208";a="870322580" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 27 Jan 2016 19:09:32 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 27 Jan 2016 19:09:32 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 27 Jan 2016 19:09:31 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0248.002; Thu, 28 Jan 2016 11:09:29 +0800 From: "Xie, Huawei" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2] fix checkpatch errors Thread-Index: AdFZeU0rtCsp1avaS8GV1jeVhOwlbw== Date: Thu, 28 Jan 2016 03:09:29 +0000 Message-ID: References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> <1453829194-56909-1-git-send-email-huawei.xie@intel.com> <9204020.3pEC1ROqZC@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.4.160] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 03:09:34 -0000 On 1/28/2016 2:17 AM, Thomas Monjalon wrote:=0A= > 2016-01-27 01:26, Huawei Xie:=0A= >> v2 changes:=0A= >> add missed commit message in v1=0A= >>=0A= >> fix the error reported by checkpatch:=0A= >> "ERROR: return is not a function, parentheses are not required"=0A= >>=0A= >> also removed other extra parentheses like:=0A= >> "return val =3D=3D 0"=0A= >> "return (rte_mempool_lookup(...))"=0A= > How these examples are differents from above checkpatch error?=0A= =0A= Don't get it.=0A= =0A= >=0A= > Please add Fixes: 6307b909b8e0 ("lib: remove extra parenthesis after retu= rn")=0A= >=0A= > This is the second run after above commit but I still see a lot of them.= =0A= > Please check git grep 'return *('=0A= >=0A= >=0A= =0A= Not a lot of them, just 44 including the document, and all of them are=0A= "return (logical expressions)", which check patch doesn't report as=0A= errors, so i chose to ignor them in the previous patch. I can send new=0A= one which also fixes those code styles.=0A= Btw, is there any reason using this style?=0A= return (a*d < b*c)=0A= =0A= This is my grep statement. Checked the error one by one.=0A= grep -P "^\s\s*return\s*\(.*" ./ -r=0A=