From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E421FC3E2 for ; Fri, 19 Feb 2016 09:10:26 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 19 Feb 2016 00:10:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,469,1449561600"; d="scan'208";a="919148752" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 19 Feb 2016 00:10:25 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 19 Feb 2016 00:10:25 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 19 Feb 2016 00:10:25 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.249]) by shsmsx102.ccr.corp.intel.com ([169.254.2.172]) with mapi id 14.03.0248.002; Fri, 19 Feb 2016 16:10:23 +0800 From: "Xie, Huawei" To: Ilya Maximets , Yuanhan Liu Thread-Topic: [PATCH RFC 2/4] vhost: make buf vector for scatter RX local. Thread-Index: AdFq7PnGlpiOHmc+Qf+PrO80tQrvfg== Date: Fri, 19 Feb 2016 08:10:22 +0000 Message-ID: References: <1455863563-15751-1-git-send-email-i.maximets@samsung.com> <1455863563-15751-3-git-send-email-i.maximets@samsung.com> <20160219070650.GS21426@yliu-dev.sh.intel.com> <56C6C4A6.2080507@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Dyasly Sergey Subject: Re: [dpdk-dev] [PATCH RFC 2/4] vhost: make buf vector for scatter RX local. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 08:10:27 -0000 On 2/19/2016 3:31 PM, Ilya Maximets wrote:=0A= > On 19.02.2016 10:06, Yuanhan Liu wrote:=0A= >> On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote:=0A= >>> Array of buf_vector's is just an array for temporary storing informatio= n=0A= >>> about available descriptors. It used only locally in virtio_dev_merge_r= x()=0A= >>> and there is no reason for that array to be shared.=0A= >>>=0A= >>> Fix that by allocating local buf_vec inside virtio_dev_merge_rx().=0A= >>>=0A= >>> Signed-off-by: Ilya Maximets =0A= >>> ---=0A= >>> lib/librte_vhost/rte_virtio_net.h | 1 -=0A= >>> lib/librte_vhost/vhost_rxtx.c | 45 ++++++++++++++++++++-----------= --------=0A= >>> 2 files changed, 23 insertions(+), 23 deletions(-)=0A= >>>=0A= >>> diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_v= irtio_net.h=0A= >>> index 10dcb90..ae1e4fb 100644=0A= >>> --- a/lib/librte_vhost/rte_virtio_net.h=0A= >>> +++ b/lib/librte_vhost/rte_virtio_net.h=0A= >>> @@ -91,7 +91,6 @@ struct vhost_virtqueue {=0A= >>> int kickfd; /**< Currently unused as polling mode is enabled. */= =0A= >>> int enabled;=0A= >>> uint64_t reserved[16]; /**< Reserve some spaces for future extensio= n. */=0A= >>> - struct buf_vector buf_vec[BUF_VECTOR_MAX]; /**< for scatter RX. */=0A= >>> } __rte_cache_aligned;=0A= >> I like this kind of cleanup, however, it breaks ABI.=0A= > Should I prepare version of this patch with field above marked as=0A= > deprecated and add note to doc/guides/rel_notes/release_16_04.rst=0A= > about future deletion?=0A= =0A= Ilya, you could follow the ABI process:=0A= http://dpdk.org/doc/guides/contributing/versioning.html=0A= =0A= >=0A= > Best regards, Ilya Maximets.=0A= >=0A= =0A=