From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <huawei.xie@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AB89058DF for <dev@dpdk.org>; Mon, 22 Feb 2016 03:08:01 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 21 Feb 2016 18:08:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,483,1449561600"; d="scan'208";a="656867020" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 21 Feb 2016 18:08:00 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 21 Feb 2016 18:08:00 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 21 Feb 2016 18:07:59 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.249]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.84]) with mapi id 14.03.0248.002; Mon, 22 Feb 2016 10:07:58 +0800 From: "Xie, Huawei" <huawei.xie@intel.com> To: Ilya Maximets <i.maximets@samsung.com>, Yuanhan Liu <yuanhan.liu@linux.intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com> Thread-Topic: [PATCH RFC 4/4] doc: add note about rte_vhost_enqueue_burst thread safety. Thread-Index: AdFq8Jaz1/1ngahpRXGW43kFOae+SQ== Date: Mon, 22 Feb 2016 02:07:56 +0000 Message-ID: <C37D651A908B024F974696C65296B57B4C5EC0DB@SHSMSX101.ccr.corp.intel.com> References: <1455863563-15751-1-git-send-email-i.maximets@samsung.com> <1455863563-15751-5-git-send-email-i.maximets@samsung.com> <20160219071046.GT21426@yliu-dev.sh.intel.com> <C37D651A908B024F974696C65296B57B4C5E7788@SHSMSX101.ccr.corp.intel.com> <56C6DACA.7040109@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.4.80] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org>, Dyasly Sergey <s.dyasly@samsung.com> Subject: Re: [dpdk-dev] [PATCH RFC 4/4] doc: add note about rte_vhost_enqueue_burst thread safety. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 22 Feb 2016 02:08:02 -0000 On 2/19/2016 5:05 PM, Ilya Maximets wrote:=0A= > On 19.02.2016 11:36, Xie, Huawei wrote:=0A= >> On 2/19/2016 3:10 PM, Yuanhan Liu wrote:=0A= >>> On Fri, Feb 19, 2016 at 09:32:43AM +0300, Ilya Maximets wrote:=0A= >>>> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>=0A= >>>> ---=0A= >>>> doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 1 +=0A= >>>> 1 file changed, 1 insertion(+)=0A= >>>>=0A= >>>> diff --git a/doc/guides/prog_guide/thread_safety_dpdk_functions.rst b/= doc/guides/prog_guide/thread_safety_dpdk_functions.rst=0A= >>>> index 403e5fc..13a6c89 100644=0A= >>>> --- a/doc/guides/prog_guide/thread_safety_dpdk_functions.rst=0A= >>>> +++ b/doc/guides/prog_guide/thread_safety_dpdk_functions.rst=0A= >>>> @@ -67,6 +67,7 @@ then locking, or some other form of mutual exclusion= , is necessary.=0A= >>>> The ring library is based on a lockless ring-buffer algorithm that ma= intains its original design for thread safety.=0A= >>>> Moreover, it provides high performance for either multi- or single-co= nsumer/producer enqueue/dequeue operations.=0A= >>>> The mempool library is based on the DPDK lockless ring library and th= erefore is also multi-thread safe.=0A= >>>> +rte_vhost_enqueue_burst() is also thread safe because based on lockle= ss ring-buffer algorithm like the ring library.=0A= >>> FYI, Huawei meant to make rte_vhost_enqueue_burst() not be thread-safe,= =0A= >>> to aligh with the usage of rte_eth_tx_burst().=0A= >>>=0A= >>> --yliu=0A= >> I have a patch to remove the lockless enqueue. Unless there is strong=0A= >> reason, i prefer vhost PMD to behave like other PMDs, with no internal= =0A= >> lockless algorithm. In future, for people who really need it, we could= =0A= >> have dynamic/static switch to enable it.=0A= =0A= Thomas, what is your opinion on this and my patch removing lockless enqueue= ?=0A= =0A= > OK, got it. So, I think, this documentation patch may be dropped.=0A= > Other patches of series still may be merged to fix existing issues and=0A= > keep code in consistent state for the future.=0A= > Am I right?=0A= =0A= Yes.=0A= =0A= > Best regards, Ilya Maximets.=0A= >=0A= =0A=