From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2A856293B for ; Thu, 2 Jun 2016 08:38:53 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 01 Jun 2016 23:38:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,405,1459839600"; d="scan'208";a="993586684" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 01 Jun 2016 23:38:51 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 1 Jun 2016 23:38:51 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.150]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.193]) with mapi id 14.03.0248.002; Thu, 2 Jun 2016 14:38:49 +0800 From: "Xie, Huawei" To: Yuanhan Liu CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue Thread-Index: AdG8mWuA9qBLtad2R2WWjDkBTDYBxA== Date: Thu, 2 Jun 2016 06:38:49 +0000 Message-ID: References: <1462323027-91942-1-git-send-email-huawei.xie@intel.com> <1464599180-76004-1-git-send-email-huawei.xie@intel.com> <20160601071546.GC10038@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2016 06:38:53 -0000 On 6/1/2016 3:13 PM, Yuanhan Liu wrote:=0A= > On Mon, May 30, 2016 at 05:06:20PM +0800, Huawei Xie wrote:=0A= >> We keep a common vq structure, containing only vq related fields,=0A= >> and then split others into RX, TX and control queue respectively.=0A= >>=0A= >> Signed-off-by: Huawei Xie =0A= >> ---=0A= >> v2:=0A= >> - don't split virtio_dev_rx/tx_queue_setup=0A= >> v3:=0A= >> - fix some 80 char warnings=0A= >> - fix other newer version checkpatch warnings=0A= >> - remove '\n' in PMD_RX_LOG=0A= > Weird, I still saw them.=0A= =0A= Maybe missed this.=0A= =0A= =0A= >=0A= > Besides that, I found a crash issue with this patch applied. You could=0A= > easily reproduce it by:=0A= >=0A= > testpmd> start tx_first=0A= > testpmd> quit=0A= >=0A= > [82774.055297] testpmd[9661]: segfault at 94 ip 00000000004f7ef0 sp 0= 0007ffcb1fa=0A= > 66c0 error 4 in testpmd[400000+25b000]=0A= > ./t.pmd: line 11: 9661 Segmentation fault (core dumped) $R= TE_SDK/$RTE=0A= > _TARGET/app/testpmd -c 0x1f -n 4 -- --nb-cores=3D4 -i --disable-hw-vl= an --txqflags=0A= > 0xf00 --rxq=3D$nr_queues --txq=3D$nr_queues --rxd=3D256 --txd=3D256= =0A= >=0A= > --yliu=0A= >=0A= =0A= Couldn't reproduce. Seems like resource free issue. Do you test with=0A= multiple queues?=0A=