From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 456CA4C8F for ; Fri, 5 Oct 2018 16:11:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 07:11:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,344,1534834800"; d="scan'208";a="269777592" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 05 Oct 2018 07:11:02 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by FMSMSX105.amr.corp.intel.com ([169.254.4.63]) with mapi id 14.03.0319.002; Fri, 5 Oct 2018 07:11:02 -0700 From: "Wiles, Keith" To: "Yigit, Ferruh" CC: dpdk-dev , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 01/10] eal: add shorthand __rte_weak macro Thread-Index: AQHUWzN5EzyfCnx+HkOO6c3gldgktqURKW0A Date: Fri, 5 Oct 2018 14:11:01 +0000 Message-ID: References: <20180803140605.43072-1-keith.wiles@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.18.77] Content-Type: text/plain; charset="us-ascii" Content-ID: <94BBD8B5B9EFBE4CA6DCD7FD6223573D@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/10] eal: add shorthand __rte_weak macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 14:11:28 -0000 > On Oct 3, 2018, at 11:09 AM, Yigit, Ferruh wrote= : >=20 > On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote: >> Signed-off-by: Keith Wiles >> --- >> lib/librte_eal/common/include/rte_common.h | 5 +++++ >> 1 file changed, 5 insertions(+) >>=20 >> diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal= /common/include/rte_common.h >> index 069c13ec7..2c4535b1a 100644 >> --- a/lib/librte_eal/common/include/rte_common.h >> +++ b/lib/librte_eal/common/include/rte_common.h >> @@ -68,6 +68,11 @@ typedef uint16_t unaligned_uint16_t; >> /******* Macro to mark functions and fields scheduled for removal *****/ >> #define __rte_deprecated __attribute__((__deprecated__)) >>=20 >> +/** >> + * short definition to mark a function or variable to a weak reference. >> + */ >> +#define __rte_weak __attribute__((__weak__)) >=20 > Looks good to me. > Reviewed-by: Ferruh Yigit >=20 > Since the change is all mechanical same change in further patches, what d= o you > think merging this patchset into single patch? I do not have a problem merging this into one, just time to do it is my big= problem. The only reason I split this up was to give each owner of the fil= e to review them. Regards, Keith