From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2805EA04BE; Sun, 6 Sep 2020 12:23:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C523B2BAB; Sun, 6 Sep 2020 12:23:20 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 32E8E1DB8 for ; Sun, 6 Sep 2020 12:23:20 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B990F302; Sun, 6 Sep 2020 06:23:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 06 Sep 2020 06:23:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= content-transfer-encoding:content-type:from:to:cc:subject:date :message-id:in-reply-to; s=fm2; bh=UwIDnkUgGmeScBFkaGz4yK3EXqe5Y uSdzFvEXFC/EPQ=; b=a7/n8UG0iCcaiMe+BnKmhYsTEWCDVh4xF/203pWnKzUFs XF01K5R+Kq9P1S0L6j9dTY7uOqHJA7O4GB4K3OyYqHJw/BM/D38EHft5jN0DDFKo U2/ztBi9NcoP9mjqabdC6bnoj6tZpTdTdNcZc9J+dbjgulqRTvE/B6EXEPrE4d8T Qb/sw54o1x0LSArKdmvM8cczCyDi3UVTvcRk+Mgeihek6vR9v58JHfGafyyExrEH eoR5gAiHJinT0AgtqxjS0hqINZHSL1CV6TGBzJscB1qUgF9h5RHrbU2VmKyLJ7nb Sjn/N393rFqRxw6WZ/46Hsa6OZ86NqJnx7nWNH9bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=UwIDnk UgGmeScBFkaGz4yK3EXqe5YuSdzFvEXFC/EPQ=; b=VSBPDrG8tMRT8J2Zg1rILY uEnI6foZPkMbwxDccVUCu9M8VtHD0xth9GTm3mYdqGONQVFqEwyYdA22mKwaFTXz xicWZ1P0oI9HcfmmWJTmhZU/B+c+FjmIeRIetvyy0cSYkF5ZyMg/sany74WE6DKh iaHlsVG+U7cD4+UHo26l5/OSTTBpPPsQEc9gXR7edV4B9SXRvaEfkaHjNFSrzws/ 8EX9azPSU8U1LqVWd1SX2g1Q/2ccp2nedrPWVXthO+22GqI14PKB8ihhiTlKYYq1 Y6ZTI1Wk7DxbcrKI9wU7Gll1+bzpSp2tlLWeLl2KdM3cCMKGKRx7pgA8XUL3QzJg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegjedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepgfgthffvufffkfgjsehtqhertddttdejnecuhfhrohhmpedfvfhhohhmrghs ucfoohhnjhgrlhhonhdfuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdehgfeludeiueehfeeifeeivdegfeevffefleduheekjeeikeek lefhffeuteefnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from localhost (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5F0E328005D; Sun, 6 Sep 2020 06:23:16 -0400 (EDT) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 From: "Thomas Monjalon" To: "Ciara Power" , Cc: "Thomas Monjalon" Date: Sun, 06 Sep 2020 12:15:32 +0200 Message-Id: In-Reply-To: <20200903152717.42095-15-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 14/37] devtools: remove use of make in scripts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu Sep 3, 2020 at 6:26 PM CEST, Ciara Power wrote: > --- a/devtools/build-tags.sh > +++ b/devtools/build-tags.sh [...] > + echo "Examples of valid configs are: " > + echo "x86_64-native-linux-gcc, arm64-armv8a-linux-gcc, > ppc_64-power8-linux-gcc" Only arch and OS are used in this script. I would give these simpler examples: x86_64-bsd, arm64-linux, ppc_64-linux [...] > --- a/devtools/check-includes.sh > +++ b/devtools/check-includes.sh > @@ -17,8 +17,7 @@ > # > # SUMMARY=3D1 is the same as -s. > # > -# CC, CPPFLAGS, CFLAGS, EXTRA_CPPFLAGS, EXTRA_CFLAGS, CXX, CXXFLAGS and > -# EXTRA_CXXFLAGS are taken into account. > +# CC, CPPFLAGS, CFLAGS, CXX, CXXFLAGS are taken into account. The comment is changed but not the script.