From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00FBAA04BE; Sun, 6 Sep 2020 12:25:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0AF9E2BAB; Sun, 6 Sep 2020 12:25:52 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id D9D0E29AC for ; Sun, 6 Sep 2020 12:25:50 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2D27BB77; Sun, 6 Sep 2020 06:25:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 06 Sep 2020 06:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= content-transfer-encoding:content-type:cc:subject:from:to:date :message-id:in-reply-to; s=fm2; bh=Lhn0+TlUsaCEAnrj9VJwEUXDDNyUR z4jHU+UlKsVe/w=; b=QW+y/8Rd9KHkbypoj5Yz0gNqdafLig4/kQSPSgInhLIXA oZ4NfggtJ8NsEtXoWMmwVZ/1xkuuJo5NjpjY1TDMpsAOUDhKnpm0b8kjc2l7iopH JE9iXQnMRGTMVPpv3V/GQqqmHWyahC2k8K0AYjd0OwINiknPdbcFrr1F3NsIAf1+ M1pNvTwwlvyxZKj5rhwmKdnedm7grK7WGfselWYVpi8+WskeCKePQLg9op7SX+Yt QYMBuNVZ94+xP9rSTjswDD2d8MCW8CwthP8fSwZz72G/ZE2eIwZXJd5EzbMxFynh pkvlcZ7udvUxla17ocQGVgvT6ass14YIeAIZq89oA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Lhn0+T lUsaCEAnrj9VJwEUXDDNyURz4jHU+UlKsVe/w=; b=aNt5Wsd0/in9OZFhAp06fL GDKH+5g1lqQ8I+PNDQbz9KG6Ibl9/vbqQH653w9oeVHj+BMYZK7Y84Mu1VbCUbft pgW6f69Uu19dHWpj67xdz8Sbmrgcc04HgINul6m1QPPJYkyjxnONlmDI+kdvJCne fK6OFCMHs8//GIvkBooz66okXXxoYtwODbLRpKZBQ1WFfruPDkGsIknxyOmRfKRe 3CrUWhlzKzLOUNS94ED3M8BvDoFskrA+D0Mq0VO9AHwy9CaH5QTa9OlIwLf2C8Av HrRnd6YUmGRqSSjgwKUBuzzz6fgTvgppdHFZd0t4UnS8vmI2cK6z2x4nyg82uLGA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegjedgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepgfgtuffhvfffkfgjsehtqhertddttdejnecuhfhrohhmpedfvfhhohhmrghs ucfoohhnjhgrlhhonhdfuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepleetheehveethedtffevtdegtefhieeivdekvdehueffheejheek hfdttdeuvedtnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from localhost (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0E5EA3064610; Sun, 6 Sep 2020 06:25:47 -0400 (EDT) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Cc: "Anatoly Burakov" , "Beilei Xing" , "Jeff Guo" From: "Thomas Monjalon" To: "Ciara Power" , Date: Sun, 06 Sep 2020 12:24:49 +0200 Message-Id: In-Reply-To: <20200903152717.42095-17-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 16/37] drivers: remove references to make config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu Sep 3, 2020 at 6:26 PM CEST, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in code comments. It should be squashed with the patch removing the config options. In general, I feel this patchset would benefit a bit more squashing.